`cli/common/tools.js` and `tools.cjs` are not covered by `npm run typecheck`
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- Half a day
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript, typescript
- Domain
- build-system
Research direction
The gap is in the include array of tsconfig.json, which lists "cli/*" and so misses the nested cli/common/ directory. Start by running npm run typecheck and confirming that cli/common/tools.js and tools.cjs are absent from the checked files, then compare with bins.cjs, which is checked only because bins.js imports it. Done means the typecheck covers both files and either passes or surfaces type errors that are then fixed.
Written by the indexing model from the issue text.
Description
Found by differential semantic drift analysis from ece8b148 to a7721303.
What is broken
cli/common/tools.js and tools.cjs, added by #8694, start with // @ts-check, but tsconfig.json includes "cli/*", which does not reach cli/common/. bins.cjs is checked only because bins.js imports it; nothing that is checked imports tools.*. So npm run typecheck never type-checks them, despite their @ts-check header.
Related: #8708 (listed in #8712) made npm run typecheck pass; these two files were added later by #8694 and fall outside it.
Possible cause (speculation only)
A guess: the include pattern was written when all CLI entry points lived directly in cli/, and the new subdirectory files were assumed to be covered.
- Dominant language
- OCaml
- Stars
- 7.5k
- Forks
- 484
- Avg merge
- 22h 10m
- Merged PRs (30d)
- 70
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from rescript-lang/rescript
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
rescript-lang/rescript#8765 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
rescript-lang/rescript#8763 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
rescript-lang/rescript#8761 ·
Maintainers usually reply within 1 day
-
Issues from differential semantic drift analysis (ece8b148 to a7721303)Possibly taken @cknitt claimed this today. Open
rescript-lang/rescript#8768 · 1 assignee ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 Half a day Newbie friendliness 55/100
rescript-lang/rescript#8767 ·
Maintainers usually reply within 1 day
All issues in rescript-lang/rescript
Similar issues
-
[request] vsg/1.1.16Openupstream update
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
conan-io/conan-center-index#31142 ·
Maintainers usually reply within 1 day
-
bot-found documentation priority: P3
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
madenvel/KalinkaPlayer#313 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
bug CMake build system
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
E3SM-Project/E3SM#8853 ·
Maintainers usually reply within 2 days