extra Compositions inside src/Video.jsx are confused and mislead

Open
#6 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript
Domain
frontend

Research direction

Inspect src/Video.jsx around lines 21–36 and src/HelloWorld.jsx around line 28 to understand how the extra Compositions relate to the Sequence. Remove the unnecessary confusing Compositions while keeping the basic HelloWorld demo intact; done means the minimal example no longer contains those redundant entries.

Written by the indexing model from the issue text.

Description

https://github.com/remotion-dev/template-helloworld-javascript/blob/a1a9655b6041f1172d6eb354ae7f27dfd74cf5d6/src/Video.jsx#L21

I think for a basic and minimal HelloWorld demo, line 21 to 36 are not nessesary in fact.
and these two extra Composition confused me a lot because there are <Logo> & <Title> & <Subtitle> inside Sequence again:
https://github.com/remotion-dev/template-helloworld-javascript/blob/a1a9655b6041f1172d6eb354ae7f27dfd74cf5d6/src/HelloWorld.jsx#L28

Dominant language
JavaScript
Stars
15
Forks
7
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from remotion-dev/template-helloworld-javascript

All issues in remotion-dev/template-helloworld-javascript

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.