Casework: activation lock-order comments still describe source reconciliation
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 94/100
Research direction
Read crates/registry-casework/src/activation.rs around lines 596–601 and 999–1012. Confirm lock_runtime_order locks only the casework_meta singleton and check why apply takes it before migration DDL. Update both comments to describe that lock and rationale; done when neither comment mentions source reconciliation progress rows.
Written by the indexing model from the issue text.
Description
Two comments in crates/registry-casework/src/activation.rs describe locks the code no longer takes:
activation.rs:596-601says source reconciliation takes its progress rows before it reads or rebinds subjects, and that apply takes both locks in order.activation.rs:999-1001documentslock_runtime_orderas locking "the casework_meta singleton, then every source reconciliation progress row".
PR #2040 removed source reconciliation. lock_runtime_order (activation.rs:1002-1012) now locks only the casework_meta singleton.
Done when both comments describe the single lock lock_runtime_order takes and why apply takes it before migration DDL.
- Dominant language
- Rust
- Stars
- 2
- Forks
- 0
- Avg merge
- 10h 47m
- Merged PRs (30d)
- 241
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from registrystack/registry-stack
-
area:release criticality:p3 documentation
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
registrystack/registry-stack#2085 ·
Maintainers usually reply within 1 day
-
area:breg bug criticality:p3 triage:needs-implementation
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
registrystack/registry-stack#2046 ·
Maintainers usually reply within 1 day
-
area:casework bug criticality:p3 rust
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
registrystack/registry-stack#1934 ·
Maintainers usually reply within 1 day
-
area:release area:scheduling bug criticality:p3 triage:needs-implementation
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
registrystack/registry-stack#1909 ·
Maintainers usually reply within 1 day
-
area:release bug
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
registrystack/registry-stack#1874 ·
Maintainers usually reply within 1 day
All issues in registrystack/registry-stack
Similar issues
-
agent duplicate providers tool triaged
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
founders_reward panics on a configured Testnet when the slow-start subsidy is not a multiple of 5Openexternal-contribution
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ZcashFoundation/zebra#11792 ·
Maintainers usually reply within 1 day
-
content:edit documentation effort:high
Difficulty 1/5 1-3 hours Newbie friendliness 67/100
cloudflare/cloudflare-docs#34428 ·
Maintainers usually reply within 1 day
-
area/cli bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100