RDT crashes page if store.subscribe is undefined
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 68/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- redux, typescript
- Domain
- developer-experience, tooling
Research direction
Start at extension/src/pageScript/index.ts around line 498 and inspect how the page script uses store.subscribe. Reproduce the issue with the sample store definition where subscribe is absent, then verify that the page no longer crashes and fails gracefully when the store does not provide that method.
Written by the indexing model from the issue text.
Description
page.bundle.js:6 Uncaught TypeError: t.subscribe is not a function
at I (page.bundle.js:6:6537)
at page.bundle.js:6:6935
at hk (main.jsx-4WfQJ2Z1.js:841:35810)
at main.jsx-4WfQJ2Z1.js:841:65460
Source code:
Sample store definition from Chrome inspect:
{
@@observable: ƒ [d]()
dispatch: ƒ s(c)
getState: ƒ i()
liftedStore: ƒ ()
replaceReducer: ƒ replaceReducer(c)
[[Prototype]]: Object
}
I think this is because RDT now has a higher Redux version requirement. But it should gracefully fail rather than crash the whole page
- Dominant language
- TypeScript
- Stars
- 14.4k
- Forks
- 1.2k
- Avg merge
- 3d 6h
- Merged PRs (30d)
- 12
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from reduxjs/redux-devtools
-
Persist setting is lost when an instance is removedPossibly taken @RaphaelFakhri claimed this 25 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
reduxjs/redux-devtools#2126 ·
Maintainers usually reply within 1 day
-
feature
Difficulty 3/5 1-2 days Newbie friendliness 45/100
reduxjs/redux-devtools#2143 ·
Maintainers usually reply within 1 day
-
connect().subscribe: calling unsubscribe twice removes another listenerPossibly taken @unknownhackerworld claimed this 16 days ago. Open
Difficulty 1/5 Under an hour Newbie friendliness 25/100
reduxjs/redux-devtools#2137 ·
Maintainers usually reply within 1 day
-
Memory leak in EdgeOpen
Difficulty 3/5 1-2 days Newbie friendliness 48/100
reduxjs/redux-devtools#2129 ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
reduxjs/redux-devtools#2125 ·
Maintainers usually reply within 1 day
All issues in reduxjs/redux-devtools
Similar issues
-
Autocomplete still accepts an option after becoming disabledPossibly taken @Xapollon430 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
reduxjs/react-redux#2416 · 1 comment ·