"husky install" is deprecated

Open
#365 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
angular, bun, typescript
Domain
tooling

Research direction

Read the prepare script in package.json and the .husky/pre-commit hook. Reproduce the warning with bun run setup, then check how updating the deprecated husky install command affects the script and hook contents. Done means setup no longer emits the deprecation warning and preserves the intended pre-commit command.

Written by the indexing model from the issue text.

Description

Steps to reproduce:

$ git clone https://github.com/realworld-apps/angular-realworld-example-app
...
$ cd angular-realworld-example-app/
$ bun run setup
...
husky - install command is DEPRECATED

with later complaints like

husky - DEPRECATED

Please remove the following two lines from .husky/pre-commit:

#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

They WILL FAIL in v10.0.0

Event if init is reccomended, it is not without issues.

From my testing with running sed -i 's/husky install/husky init/' package.json before running bun setup it then messes up package.json and changes it to ONLY

 "prepare": "husky"

removing the init argument placed there...

Also the .husky\pre-commit changed from running npx lint-staged to run bun test.

Dominant language
TypeScript
Stars
5.7k
Forks
3.5k
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from realworld-apps/angular-realworld-example-app

All issues in realworld-apps/angular-realworld-example-app

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.