[0.88] SwiftPM: move injected build settings and build scripts out of project.pbxproj
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 42/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- react-native, swift
- Domain
- build-system, release
Research direction
Start by reading the linked SwiftPM change in PR #58834 and the prerequisite PR #59043, then inspect the new ReactNativeSPM/ folder and its committed build settings and build-phase scripts. Make sure the SwiftPM opt-ins for RN_STRICT_API and RN_ALLOW_FRAMEWORKS are present before applying the move. Done means the injected settings and scripts are outside project.pbxproj and an spm update no longer changes that file.
Written by the indexing model from the issue text.
Description
Target Branch
0.88
Link to commit or PR to be picked
https://github.com/react/react-native/pull/59313
Description
A routine SwiftPM spm update, such as a React Native version bump, no longer changes project.pbxproj. The build settings and build-phase scripts that React Native adds now go into committed files in a new ReactNativeSPM/ folder.
This is a port PR against 0.88-stable of #58834, which already landed in main. We opened it to avoid merge conflicts. It is PR 5 of 5 in a stack (#59309, #59310, #59311, #59312, #59313); merge them in that order.
The commit on main also contains changes from #59043, which is not on 0.88-stable. This port leaves those changes out, so #59043 does not need to be picked.
- Dominant language
- No language data
- Stars
- 429
- Forks
- 11
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from reactwg/react-native-releases
-
Type Pick Request
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
reactwg/react-native-releases#1456 · 1 comment ·
-
Type Pick Request
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
reactwg/react-native-releases#1435 · 1 comment ·
-
Type Pick Request
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
reactwg/react-native-releases#1427 · 1 comment ·
-
Type Pick Request
Difficulty 1/5 Under an hour Newbie friendliness 78/100
reactwg/react-native-releases#1349 · 1 comment · 1 reaction ·
-
Type Pick Request
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
reactwg/react-native-releases#1326 · 1 comment ·
All issues in reactwg/react-native-releases
Similar issues
-
matplotlibOpen
Difficulty 1/5 Under an hour Newbie friendliness 73/100
nansencenter/xhycom#29 ·
-
prerender: wait for env-runner worker readiness before crawlingPossibly taken @sarankumar1325 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
area:breg bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
registrystack/registry-stack#2307 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
db-ux-design-system/core-web#8595 ·
Maintainers usually reply within 1 day