Writable: use foldLeft so the updated value is carried
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
Research direction
Start at core/src/main/scala/com/phasmidsoftware/tableparser/core/write/Writable.scala:70, the fold the review comment flags, and read the surrounding method to see how the accumulator o is threaded through each step. Compare against the foldLeft usages elsewhere in the core module to match house style. Done means the updated value is carried into each iteration and the core write tests (core module test suite) still pass.
Written by the indexing model from the issue text.
Description
core/src/main/scala/com/phasmidsoftware/tableparser/core/write/Writable.scala:70:
CONSIDER using foldLeft so that we can use the updated value of o at each step.
As written, the updated value is discarded at each step, which may be a defect rather than a style point.
- Dominant language
- Scala
- Stars
- 11
- Forks
- 4
- Avg merge
- 6h 54m
- Merged PRs (30d)
- 52
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from rchillyard/TableParser
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
rchillyard/TableParser#206 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
rchillyard/TableParser#195 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
rchillyard/TableParser#194 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
rchillyard/TableParser#193 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
rchillyard/TableParser#186 ·
Maintainers usually reply within 1 day
All issues in rchillyard/TableParser
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 2 days
-
? - Needs Triage bug
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
NVIDIA/cudf-spark#17063 ·
Maintainers usually reply within 2 days
-
bug 🐞 User issue 🚨
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
valkey-io/valkey-glide#7813 · 2 comments ·
Maintainers usually reply within 1 day
-
[CORE] Selecting a cost model the backend has no coster for fails with ClassNotFoundExceptionPossibly taken @LuciferYang claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 3 days