Move to Visitor 1.8.0 and drop the logback exclusion

Open Beginner friendly
#132 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
1-3 hours
Newbie friendliness
91/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
scala
Domain
build-system

Research direction

In build.sbt, update visitorVersion from 1.7.0 to 1.8.0 and remove the logback-classic exclusion from the Visitor dependency. Start by checking the dependency declaration and the published Visitor 1.8.0 POM referenced in the issue. Run the build; done means it passes with the updated dependency and no exclusion.

Written by the indexing model from the issue text.

Description

Visitor 1.8.0 was released on 2026-11-17. Two lines in build.sbt should change:

val visitorVersion = "1.7.0"   // -> "1.8.0"

"com.phasmidsoftware" %% "visitor" % visitorVersion exclude("ch.qos.logback", "logback-classic"),
//                                                  ^^^^^^^ no longer needed

The exclusion can go

It was there because Visitor published logback-classic at Runtime scope, putting a logging backend on every consumer's classpath — a library should not do that. 1.8.0 fixes it, confirmed against the published POM on Central, not just Visitor's build.sbt:

<dependency>
    <groupId>ch.qos.logback</groupId>
    <artifactId>logback-classic</artifactId>
    <version>1.5.32</version>
    <scope>test</scope>
</dependency>

The breaking changes should not affect us

1.8.0 is a deliberate binary break — under PVP the first two numbers form the major version — but none of it touches what TableParser uses.

TableParser references Visitor in exactly one file: core/src/main/scala/com/phasmidsoftware/tableparser/core/util/TopN.scala, which imports com.phasmidsoftware.visitor.core.PrioQueue. And git diff V1.7.0 V1.8.0 -- PrioQueue.scala in the Visitor repository is empty — that class did not change at all in 1.8.0.

For the record, the four breaking changes were: removal of core.Zero and core.Monoid; Visitor generalised over its journal's element type; visit losing its using Evaluable; and Appendable becoming F-bounded. None is reachable from PrioQueue.

So this is expected to be a two-line change plus a green build. If it turns out not to be, that is itself worth knowing.

Is there anything to "take advantage of"?

Open question, and the reason this issue is scoped the way it is. 1.8.0's new surface is traversal machinery — a Java API, SimpleVisitor, Traverse, ParentedVisitor, Traversal.dfsTracking — and TableParser is not a graph library; it uses Visitor solely for a priority queue. Nothing in the new API has an obvious use here.

If there is a use in mind, it belongs in a separate issue rather than being folded into this one, which should stay a dependency hygiene change.

Note on branching

main is the right base. At the time of filing the working checkout is on crime_brief_test with an uncommitted CrimeSpec.scala, so this wants a clean branch rather than being done in passing.

Dominant language
Scala
Stars
11
Forks
4
Avg merge
2h 40m
Merged PRs (30d)
44

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rchillyard/TableParser

All issues in rchillyard/TableParser

Similar issues

More Scala issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.