hardware_pll doxygen doesn't mention RP2350
Maintainers usually reply within 6 days
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 91/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- c
- Domain
- documentation
Research direction
Read the Doxygen comment near line 17 of src/rp2_common/hardware_pll/include/hardware/pll.h and compare it with the RP2350 datasheet details quoted in the issue. Update the documentation to cover RP2350's two PLLs and its 150 MHz system clock while retaining the RP2040 information. Done when the rendered hardware_pll documentation describes both chips accurately.
Written by the indexing model from the issue text.
Description
https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/hardware_pll/include/hardware/pll.h#L17 (see here for the rendered output) currently talks about the PLLs in RP2040, but makes no mention of RP2350.
The RP2350 datasheet says:
There are two PLLs in RP2350. They are:
• pll_sys - used to generate up to a 150 MHz system clock
• pll_usb - used to generate a 48 MHz USB reference clock
So it seems the only change is a 133MHz system clock for RP2040 but 150MHz for RP2350.
- Dominant language
- C
- Stars
- 5k
- Forks
- 1.3k
- Avg merge
- 12d 19h
- Merged PRs (30d)
- 5
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from raspberrypi/pico-sdk
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
raspberrypi/pico-sdk#3300 ·
Maintainers usually reply within 6 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
raspberrypi/pico-sdk#3292 ·
Maintainers usually reply within 6 days
-
Add masked GPIO pull configuration APIsPossibly taken A pull request linked to this issue is open or already merged. Openhardware_gpio
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
raspberrypi/pico-sdk#3279 ·
Maintainers usually reply within 6 days
-
multicore_lockout_handler calling non-inlined multicore_fifo_push_blocking_inlinePossibly taken @Wooohaaa claimed this 2 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
raspberrypi/pico-sdk#3225 · 2 comments ·
Maintainers usually reply within 6 days
-
pioasm: support set x -1Possibly taken A pull request linked to this issue is open or already merged. Openpioasm
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
raspberrypi/pico-sdk#3205 · 2 comments ·
Maintainers usually reply within 6 days
All issues in raspberrypi/pico-sdk
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
slice
Difficulty 2/5 Under an hour Newbie friendliness 72/100
Life-Framework/Life-Framework#3465 ·
Maintainers usually reply within 1 day