refactor(local-libvirt): use the local operation in external_boot_authority._commit
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 84/100
Research direction
Read src/kdive/providers/local_libvirt/external_boot_authority.py around _commit lines 603–609 and compare the neighbouring guards. Change the guard to use the local operation, then run the existing test suite; done when _commit uses one name for the operation in those checks.
Written by the indexing model from the issue text.
Description
Problem
In _commit, one guard reads request.operation while the neighbouring guard and the rest of the function use the local operation that commit obtained from _require_permitted_commit_point. _require_permitted_commit_point ties the two together (src/kdive/providers/local_libvirt/external_boot_authority.py:~521-524), so today they are equal; the mix invites divergence.
Evidence
(Line numbers moved from ~574.)
- src/kdive/providers/local_libvirt/external_boot_authority.py:603-607:
allow_cleanup_receipt=operation in _DELETING_OPERATIONSthenrequest.operation in _DELETING_OPERATIONStwo lines later; :609 usesoperation. - Same file :725-735 (
_observe) usesrequest.operationthroughout, correctly, because it has no local.
Expected
_commit uses one name for the operation.
Proposed approach
Change request.operation to operation at :607. One line; no test needed beyond the existing suite.
Provenance
Follow-up from campaign 4c2c8dc9e59d-7f9a87f5-2251-458a-bb30-04fbb2d4b05c.
- Dominant language
- Python
- Stars
- 0
- Forks
- 0
- Avg merge
- 9h 13m
- Merged PRs (30d)
- 197
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from randomparity/kdive
-
area:core-platform effort:S priority:P3 risk:night-safe status:ready type:test
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
randomparity/kdive#3620 ·
Maintainers usually reply within 1 day
-
area:providers effort:S priority:P3 risk:night-watch status:ready type:docs
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
randomparity/kdive#3618 ·
Maintainers usually reply within 1 day
-
area:core-platform effort:S priority:P3 risk:night-safe status:ready type:test
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
randomparity/kdive#3603 ·
Maintainers usually reply within 1 day
-
area:providers effort:S priority:P3 risk:night-safe status:ready type:docs
Difficulty 1/5 1-3 hours Newbie friendliness 82/100
randomparity/kdive#3593 ·
Maintainers usually reply within 1 day
-
area:providers effort:S priority:P3 risk:night-safe status:ready type:docs
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
randomparity/kdive#3591 ·
Maintainers usually reply within 1 day
All issues in randomparity/kdive
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
FinanceFlash/unvibecode#760 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
google-research/google-research#3470 ·
Maintainers usually reply within 21 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
mrvautin/ha-workouts#11 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
laramies/theHarvester#2666 ·
Maintainers usually reply within 3 days