Feature request: Change `HTMLWidgets.shinyMode` to integers 0, 1, 2...
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
Research direction
Start by tracing the HTMLWidgets.shinyMode entry point and review the linked rmarkdown issue for the shinyrmd and shiny_prerendered runtime behavior. Define whether the existing flag should become integer-valued or a separate runtimeMode should be added, then verify the three requested states without breaking existing widget integrations.
Written by the indexing model from the issue text.
Description
Recently I was trying to render the htmlwidgets in rmarkdown with shinyrmd runtime, but then I encountered rendering errors.
The reason is because when rendered in shinyrmd or shiny_prerendered runtime, Shiny has invalid onInputChanged method. This will invalidate many widgets that are expecting this feature, for example, visNetwork and threeBrain, etc. are expecting to communicate with shiny, which will definitely fail.
Please see more details from this issue: https://github.com/rstudio/rmarkdown/issues/2232
I was wondering if HTMLWidgets.shinyMode could be integers such that:
HTMLWidgets.shinyMode=0means no shiny is detectedHTMLWidgets.shinyMode=1means shiny is detected and is in normal dashboard mode orshinyruntime in rmarkdownsHTMLWidgets.shinyMode=2means shiny is detected but rendered inrmarkdownwithshinyrmdorshiny_prerenderedruntime
If this change could break many packages, when maybe add HTMLWidgets.runtimeMode?
- Dominant language
- R
- Stars
- 801
- Forks
- 202
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ramnathv/htmlwidgets
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
ramnathv/htmlwidgets#307 · 2 reactions ·
-
Difficulty 3/5 1-2 days Newbie friendliness 52/100
ramnathv/htmlwidgets#495 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
ramnathv/htmlwidgets#492 · 2 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
ramnathv/htmlwidgets#489 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
ramnathv/htmlwidgets#488 · 1 comment ·
All issues in ramnathv/htmlwidgets
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
databrickslabs/brickster#320 ·
Maintainers usually reply within 3 days
-
Add a renv.lockOpen
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
[Bug]: Note on R CMD checkPossibly taken @llrs-roche claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
insightsengineering/osprey#157 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
urbio-ecology/urbioconnect#182 ·
Maintainers usually reply within 1 day