Make connection/channel close idempotent

Open
#356 0 comments 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

@acogoluegnes is already working on this.

Since Apr 4, 2018.

Assessment

This issue has not been assessed yet.

Description

effort-low usability

It could be useful to be able to call Connection/Channel#close several times safely, or to have a flag to know closing is in-progress. See https://github.com/reactor/reactor-rabbitmq/commit/053b2f0e0646b37d64216d55656534759559f055.

This would be just a matter of using an AtomicBoolean and be careful with corner cases.

Dominant language
Java
Stars
1.3k
Forks
590
Avg merge
10h 1m
Merged PRs (30d)
53

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rabbitmq/rabbitmq-java-client

All issues in rabbitmq/rabbitmq-java-client

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.