hub-client: "Expand markup" and "Expand preview" should hide the other pane instead of shrinking it
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 72/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
- Domain
- frontend
Research direction
Start with hub-client/src/components/ViewToggleControl.tsx and hub-client/src/components/Editor.tsx to trace how split presets reach the pane layout; then read hub-client/src/components/Editor.css and hub-client/src/components/DocumentTopBar.tsx. Check how PreviewRouter supplies diagnostics before changing pane visibility. Done means each expand button hides the other pane and divider, equal split restores both with current content, diagnostics keep updating, and files without previews remain unchanged.
Written by the indexing model from the issue text.
Description
Goal
In the editor's document header, "Expand markup" and "Expand preview" hide the other pane instead of shrinking it. "Split equally" is unchanged.
Today each expand button moves the pane divider to its drag limit, which leaves the other pane at 15% of the editing area's width. The markup pane is the source editor on the left. The preview pane is the rendered document on the right.
Done means:
- After "Expand markup", only the markup pane is on screen. After "Expand preview", only the preview pane is. Nothing of the other pane remains, divider included.
- "Split equally" brings both panes back at 50/50, and the pane that was hidden shows the current content.
- The button for the current layout shows as active.
- The editor's diagnostics (error markers in the markup pane) keep updating while the preview is hidden.
- Files with no preview pane (images, plain-text files such as
.ymlor.css) behave as today: the buttons stay disabled and the editor stays visible.
Why
A shrunk pane is a narrow strip that only makes sense to someone who already knows what it is.
- "Expand preview" leaves the markup as a 15% column of squashed raw text next to the rendered document. A user who knows little Markdown and works in the preview, where paragraphs can be edited in place (WYSIWYG), reads that column as noise.
- "Expand markup" has the mirror problem: the rendered document is squeezed into a narrow 15% column.
- A hidden pane gives the chosen pane the whole width, and the screen shows what the button says.
- The header's fullscreen-preview action is not a substitute: it also hides the header and the sidebar.
The presets mirror the drag limits today (see the comment above SPLIT_PRESETS). This issue suggests letting the two expand buttons go past them, while a drag keeps its 15–85% limits.
References
Code pointers (main at f4a3853):
hub-client/src/components/ViewToggleControl.tsx: the three buttons;SPLIT_PRESETS0.85 / 0.5 / 0.15.hub-client/src/components/DocumentTopBar.tsx: renders the buttons fromsplitFraction,onSetSplitandsplitDisabled.hub-client/src/components/Editor.tsx:editorPaneFraction,handleSetSplitPreset(does not clamp), the drag handler (clamps to 0.15–0.85), each pane'sflex, and the.pane-divider.hub-client/src/components/Editor.css:.pane,.pane-divider,.split-animating.
One possible approach, from reading the code (not tried in a browser):
- Have the expand buttons send 1 (markup only) or 0 (preview only) instead of 0.85 or 0.15. A drag cannot produce either value, so they can identify the collapsed state.
- Hide the collapsed pane and the divider, for example with CSS keyed on that state.
- Hide the preview rather than unmount it:
PreviewRouterfeeds the editor's diagnostics (onDiagnosticsChange). - The
viewModemodes ('markup'and'preview'inViewModeContext.tsx, with the.view-mode-*rules inEditor.css) are no shortcut: nothing callssetViewMode, and those rules shrink the other pane to a strip of roughly 120–220 px instead of hiding it.
- Dominant language
- Rust
- Stars
- 302
- Forks
- 22
- Avg merge
- 5h 2m
- Merged PRs (30d)
- 213
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from quarto-dev/q2
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
quarto-dev/q2#1219 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
quarto-dev/q2#1188 · 3 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
quarto-dev/q2#1179 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
quarto-dev/q2#1133 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
quarto-dev/q2#1103 · 1 comment ·
Maintainers usually reply within 1 day
Similar issues
-
priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
storytold/photocraft#15350 ·
Maintainers usually reply within 1 day
-
area:davinci
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ubugeeei-prod/vize#13167 ·
Maintainers usually reply within 1 day
-
area:ui enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
transit-audio/transit#738 ·
Maintainers usually reply within 1 day
-
enhancement good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 91/100
hocinehacherouf/liberarr#78 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day