Make python-fx an optional dependency
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 70/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- python
- Domain
- build-system
Research direction
Start by inspecting the dependency declarations in pyproject.toml, then compare their optional-dependency groups with the angr example linked in the issue. Verify that a core qiling installation no longer pulls in python-fx while users can still opt into the related dependency group.
Written by the indexing model from the issue text.
Description
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I use qiling in a python project to emulate binaries. It's an awesome project thanks a lot !
Nevertheless each time I build it, it imports loads of dependencies that I don't need and don't use, especially python-fx, that imports pillow, which
- crouds my github security advisory with vulnerabilities in pillow,
- limits the python versions my project can build for.
Describe the solution you'd like
Send us a pull request always help, or any pseudo code might be useful.
At the moment I do a manual override to say that I don't need python-fx in my pyproject.toml, but I would really like it if qiling could implement blocks of optionnal dependencies groups (such as this other RE project angr does :
https://github.com/angr/angr/blob/9af373689f450717ec0d0b8be0daed2477a091ee/pyproject.toml#L81-L99
So as people using qiling as a dependency can only import the core of a qiling in their projects.
Thanks a lot
- Dominant language
- Python
- Stars
- 6.1k
- Forks
- 798
- Avg merge
- 2h 53m
- Merged PRs (30d)
- 9
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from qilingframework/qiling
-
Difficulty 2/5 Half a day Newbie friendliness 82/100
qilingframework/qiling#1640 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 78/100
qilingframework/qiling#1628 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
qilingframework/qiling#1460 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
qilingframework/qiling#1458 ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
qilingframework/qiling#1645 · 2 comments ·
Maintainers usually reply within 1 day
All issues in qilingframework/qiling
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
FuRongJun-1999/dsh-memory#56 ·
Maintainers usually reply within 1 day
-
Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
pgadmin-org/pgadmin4#10503 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
521xueweihan/HelloGitHub#3857 ·
-
needs-ac
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Ikalus1988/MisakaNet#2845 ·
Maintainers usually reply within 1 day
-
bug connectors operations
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
pyinfra-dev/pyinfra#1989 ·
Maintainers usually reply within 3 days