Remove unused FVS_* macros
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 78/100
Research direction
The issue identifies FVS_MASK and FVS_HAVE_SPEC in Include/ceval.h as unused after the FORMAT_VALUE opcode removal in Python 3.13. Read their definitions and search the codebase for remaining references. Done means removing the unused macros without a deprecation period and confirming no references remain.
Written by the indexing model from the issue text.
Description
Feature or enhancement
The macros FVS_MASK and FVS_HAVE_SPEC, which are defined in Include/ceval.h, are unused in the cpython code base. They are left over from the removal of the FORMAT_VALUE opcode in python 3.13: they were used to determine if an f-string had a format spec or not. I do not think they need a deprecation period: they were never documented, and any use of them would be unrelated to their original purpose.
I've discussed this with @vstinner who agreed that we don't need a deprecation period.
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
- Dominant language
- Python
- Stars
- 77.7k
- Forks
- 38.3k
- Avg merge
- 12h 27m
- Merged PRs (30d)
- 645
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from python/cpython
-
tests topic-profiling type-bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
extension-modules type-bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
tests topic-multiprocessing type-bug
Difficulty 2/5 1-3 hours Newbie friendliness 71/100
Maintainers usually reply within 1 day
-
extension-modules type-bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
python/cpython#160001 · 3 comments ·
Maintainers usually reply within 1 day
-
stdlib topic-XML type-bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
Similar issues
-
Python Volcengine provider returns failures instead of raising themPossibly taken @Ricardo-M-L claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
agent-infra/sandbox#248 ·
-
Textractor leaves empty temporary files when remote retrieval failsPossibly taken @HuaTNA claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
test(bm_generation): pin the learning parameters and CPU sync shortcutPossibly taken @iloveeyjafjalla claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
qboson/kaiwu-pytorch-plugin#1341 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
elder-plinius/V3R1T4S#625 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
foxglove/mcap#1907 · 1 comment ·
Maintainers usually reply within 1 day