Extend ASYNC401 to other forms
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 68/100
Research direction
Start by locating the ASYNC401 implementation and its tests in the repository. Compare the rule's handling of the listed pytest.raises, pytest.RaisesExc, pytest.RaisesGroup, and pytest.mark.xfail forms, then update coverage so the equivalent ExceptionGroup usages are reported as described.
Written by the indexing model from the issue text.
Description
I was looking at implementing ASYNC401 in Ruff and noticed that there are a couple forms that the rule here doesn't capture but arguably should.
pytest.mark.xfail(raises=ExceptionGroup)could bepytest.mark.xfail(raises=pytest.RaisesGroup(...))pytest.RaisesGroup(ExceptionGroup)could bepytest.RaisesGroup(pytest.RaisesGroup(...))pytest.raises(ExceptionGroup[Exception])andpytest.RaisesExc(ExceptionGroup)are ignored even though they are equivalent topytest.raises(ExceptionGroup)
Would there be interest in updating the rule to report on the usages above as well?
- Dominant language
- Python
- Stars
- 26
- Forks
- 10
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from python-trio/flake8-async
-
rule improvement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
python-trio/flake8-async#457 · 1 reaction ·
-
new rule
Difficulty 3/5 1-2 days Newbie friendliness 55/100
python-trio/flake8-async#454 · 1 comment ·
-
rule improvement
Difficulty 3/5 1-2 days Newbie friendliness 62/100
python-trio/flake8-async#447 · 5 comments ·
-
good first issue
Difficulty 5/5 Over a week Newbie friendliness 15/100
python-trio/flake8-async#396 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
python-trio/flake8-async#395 · 8 comments ·
All issues in python-trio/flake8-async
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
xinnan-tech/xiaozhi-fde-talk#263 ·
-
rules
Difficulty 1/5 Under an hour Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
huggingface/Repo2RLEnv#163 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 95/100
huggingface/sentence-transformers#4074 ·
-
comp/dashboard invalid P3
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
NousResearch/hermes-agent#121143 ·