ASYNC103 for sync functions

Open

#447 opened on Apr 22, 2026 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 3/5
Estimated time: 1-2 days
Newbie friendliness: 62/100

Issue type: Bug
Clarity: Mostly clear
Activity status: Quiet
Tech stack: python
Domain: tooling

Research direction

Start by reproducing ASYNC103 against the sync call shown in src/trio/_core/_instrumentation.py and inspect how the rule distinguishes synchronous and asynchronous functions. Done means the false positive is no longer reported while the intended ASYNC103 cases still are; add or update the relevant regression test once its location is identified.

Written by the indexing model from the issue text.

Description

rule improvement

I don't think sync functions can raise trio.Cancelled, but this is causing ASYNC103:

    def call(
        self,
        hookname: str,
        *args: object,
    ) -> None:
        # snip
        for instrument in list(self.data[hookname]):
            try:
                getattr(instrument, hookname)(*args)
            except BaseException:  # E
                self.remove_instrument(instrument)
                INSTRUMENT_LOGGER.exception(
                    "Exception raised when calling %r on instrument %r. "
                    "Instrument has been disabled.",
                    hookname,
                    instrument,
                )

Error message:

src/trio/_core/_instrumentation.py:110:20: ASYNC103 BaseException block with a code path that doesn't re-raise the error. Consider adding an `except trio.Cancelled: raise` before this exception handler.

Dominant language: Python
Stars: 26
Forks: 10
PR merge metrics: No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

issue: imported chats all show as unread in the sidebar Open

bug confirmed issue

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

open-webui/open-webui#30750 · 1 comment · Opened Sep 24, 2026
OGS AmBe example has no source.timing block, so every event sits at time zero Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

lanl/ScintiPix#61 · Opened Sep 24, 2026
Make Liquid Glass the default theme for the Research build Open

enhancement

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

OpenwaterHealth/openmotion-bloodflow-app#604 · 1 comment · Opened Sep 24, 2026
tests/puppeteer/test_openai_api_key_ui.js targets controls that do not exist and is run by no workflow Open

Difficulty 2/5 1-3 hours Newbie friendliness 70/100

LearningCircuit/local-deep-research#6766 · Opened Sep 23, 2026
Delete unused args argument from main() in Python files Open

good first issue

Difficulty 1/5 Under an hour Newbie friendliness 90/100

ros2/launch#1014 · Opened Sep 23, 2026

More Python issues