Reports spec as valid when other validators do not

Open
#89 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
openapi, python
Domain
api, testing-qa

Research direction

Start with test_validators.py and the test_parameter_default_value_wrong_type_swagger testcase mentioned in the report. Reproduce the case with duplicate 200 responses and trace the validator path that accepts it. Done means a regression test captures the duplicate-response case and the validator reports it as invalid.

Written by the indexing model from the issue text.

Description

I have a spec which this project reports as valid where other validators, such as speccy, do not.

What I've found is that the spec we were using had duplicate entries for a get response of 200. This causes the other validators to throw an error.

I modified the test_parameter_default_value_wrong_type_swagger testcase in test_validators.py to add a duplicate 200 response with a different description and the error was not reported.

Dominant language
Python
Stars
409
Forks
73
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from python-openapi/openapi-spec-validator

All issues in python-openapi/openapi-spec-validator

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.