deprecate passing None as a plugin instance
Maintainers usually reply within 1 day
Nobody has claimed this yet.
- #791 by @MbappeWU — closed without merging
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 30/100
Research direction
Start with the discussion in #749 and the closed, unmerged pull request #791, which is linked here, to learn why it was not merged before you begin. The issue asks for a deprecation warning when None is passed as a plugin instance, so find where plugins are registered in pluggy and check how existing deprecations are emitted. Done means a warning is raised for None and a test confirms it.
Written by the indexing model from the issue text.
Description
Lets add a deprecation warning
Originally posted by @RonnyPfannschmidt in #749
- Dominant language
- Python
- Stars
- 1.7k
- Forks
- 187
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 24
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from pytest-dev/pluggy
-
Plugin registry compares plugins by equality, not identityPossibly taken @00200200 claimed this 7 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
pytest-dev/pluggy#760 ·
Maintainers usually reply within 1 day
-
Hook tracing crashes with specced Mock arguments and resultsPossibly taken @RonnyPfannschmidt claimed this 1 day ago. Open
Difficulty 2/5 Half a day Newbie friendliness 25/100
pytest-dev/pluggy#792 · 2 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
Defaulted positional-only hook parameters are forwarded as keywordsPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 4/5 1-2 days Newbie friendliness 45/100
pytest-dev/pluggy#774 · 3 comments ·
Maintainers usually reply within 1 day
-
unregister() argument validation relies on assertPossibly taken @ekanshul claimed this 8 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 42/100
pytest-dev/pluggy#762 ·
Maintainers usually reply within 1 day
-
Failures during add_hookspecs / historic replay leave partial statePossibly taken @starx710 claimed this 4 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 50/100
pytest-dev/pluggy#761 ·
Maintainers usually reply within 1 day
All issues in pytest-dev/pluggy
Similar issues
-
Examples say cnxOpendocumentation embedded
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Alishahryar1/free-claude-code#2111 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
namespace operations
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
EclipseFdn/open-vsx.org#14373 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day