hook call controller in hook specs
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- python
- Domain
- developer-experience, tooling
Research direction
Start by reviewing the existing hook specifications and the HookCallConfig example in the issue, then compare the proposed direction with issue #151. The work is complete when the hook-spec API is agreed, its parameter-validation and modification behavior is specified, and the resulting behavior is covered by tests.
Written by the indexing model from the issue text.
Description
currently hook specs just provide the parameters
if it was allowed to have them provide more details, this could be a win
a very initial draft is something like
python
@hookspec
def pytest_something_with_paths(call_config: HookCallConfig, path: Path | None = None, oldpath: py.path.local |None = None ) -> ...
if path is None and old_path is None:
rasie TypeError(...)
return call_config.set_parameters(....)
i'd love to bikeshed apis a bit
its also a possible replacement to #151
cc @goodboy @nicoddemus @bluetech
- Dominant language
- Python
- Stars
- 1.7k
- Forks
- 170
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 16
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from pytest-dev/pluggy
-
[Downstream] devpi broken - trying to register `None`Possibly taken @bluetech claimed this 4 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 58/100
pytest-dev/pluggy#749 · 4 comments ·
Maintainers usually reply within 1 day
-
How to handle keyword-only argumentsPossibly taken @bluetech claimed this 9 days ago. Open
pytest-dev/pluggy#742 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
pytest-dev/pluggy#705 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 20/100
pytest-dev/pluggy#628 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
pytest-dev/pluggy#588 · 1 reaction ·
Maintainers usually reply within 1 day
All issues in pytest-dev/pluggy
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
FuRongJun-1999/dsh-memory#56 ·
Maintainers usually reply within 1 day
-
Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
pgadmin-org/pgadmin4#10503 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
521xueweihan/HelloGitHub#3857 ·
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
rai-opensource/spatialmath-python#235 ·
Maintainers usually reply within 1 day
-
needs-ac
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Ikalus1988/MisakaNet#2845 ·
Maintainers usually reply within 1 day