deprecate passing classes as hookspecs, it shold be instances
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
Research direction
Start by reading the hook-spec registration and handling code, then review the discussion on pull request #359 linked from the issue. Determine where classes and instances are currently treated differently and where the new bound-method handling applies. Done means hook specs consistently require instances and the legacy class-handling path is deprecated or removed.
Written by the indexing model from the issue text.
Description
we currently have self magic in place to handle unbound methods and passed in classes
ass signature (see #359) handles the bound methods so much better, we should ensure hook-specs are instances not types, and then generally handle them that way
followup to https://github.com/pytest-dev/pluggy/pull/359#discussion_r936410218_
- Dominant language
- Python
- Stars
- 1.7k
- Forks
- 170
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 16
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from pytest-dev/pluggy
-
Difficulty 3/5 1-2 days Newbie friendliness 58/100
pytest-dev/pluggy#749 · 4 comments ·
Maintainers usually reply within 1 day
-
How to handle keyword-only argumentsPossibly taken @bluetech claimed this 7 days ago. Open
pytest-dev/pluggy#742 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
pytest-dev/pluggy#705 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 20/100
pytest-dev/pluggy#628 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
pytest-dev/pluggy#588 · 1 reaction ·
Maintainers usually reply within 1 day
All issues in pytest-dev/pluggy
Similar issues
-
#bug
Difficulty 1/5 Under an hour Newbie friendliness 92/100
apache/superset#44923 · 1 comment ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
lawndoc/stack-back#123 ·
-
Add: EntuneOpen
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
AbdelStark/awesome-typesafe-jev#187 ·
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
repowise-dev/repowise#2966 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 2 days