tracing: store called hook_impls
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
Research direction
Start with src/pluggy/callers.py around lines 195-198 and trace how _Result is created and consumed. Then inspect the tracing path and existing hook_impl handling to clarify whether storage is optional and what information it should retain. Done requires an agreed scope and observable behavior for identifying called implementations.
Written by the indexing model from the issue text.
Description
With tracing I think it would be good to know where the result is coming from (firstresult=True), and/or which hook_impls have been called in general.
But this could also be useful to know in general, so storing it (optionally?) on the _Result seems like a good idea to me.
It should probably not be full references (except for when tracing is enabled, but that's not easy to know when creating the _Result it seems), but only the plugin_name by default.
Related code: https://github.com/pytest-dev/pluggy/blob/a5130ac87a71865192db3959d2e1e1ac41daaca7/src/pluggy/callers.py#L195-L198
- Dominant language
- Python
- Stars
- 1.7k
- Forks
- 170
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 16
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from pytest-dev/pluggy
-
Difficulty 3/5 1-2 days Newbie friendliness 58/100
pytest-dev/pluggy#749 · 4 comments ·
Maintainers usually reply within 1 day
-
How to handle keyword-only argumentsPossibly taken @bluetech claimed this 7 days ago. Open
pytest-dev/pluggy#742 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
pytest-dev/pluggy#705 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 20/100
pytest-dev/pluggy#628 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
pytest-dev/pluggy#588 · 1 reaction ·
Maintainers usually reply within 1 day
All issues in pytest-dev/pluggy
Similar issues
-
tool-calling
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
vllm-project/vllm#59838 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
raullenchai/Rapid-MLX#4042 ·
Maintainers usually reply within 1 day
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 92/100
transitmatters/mbta-slow-zone-bot#70 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
litestar-org/advanced-alchemy#811 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day