Move sofar-related pyfar functionality to sofar
@f-brinkmann is already working on this.
Since Aug 21, 2026.
Assessment
This issue has not been assessed yet.
Description
In https://github.com/pyfar/pyfar/issues/958, we decided to
- move the functionality
pyfar.io.read_sofaandconvert_sofato sofar - implement possibly identical behavior to the classes
SofaandSofaStream - improve flexibility to return arbitrary coordinates
I would suggest to add methods as_audio_object and as_coordinates.
as_audio_object()
- will return values in
Sofa.Dataas a pyfarSignalorFrequencyDatadepnding on the data type of the Sofa object - In case of
SofaStreamit could have an addition parametersliceto determine which data is returned
as_coordinates(attribute)
- works as the above, with
attributedetermining which data of the Sofa object is returned as coordinates - also has the additional
sliceparameter forSofaStream
The only difference between Sofa and SofaStream methods is how the actual data is obtained. Everything else can be moved into shared private functions to avoid redundant code.
If we consider this to be some kind of I/O functionality, it might be more consistent to implement this as sofar.as_audio_object otherwise it could be Sofa.as_audio_object and SofaStream.as_audio_object.
- Dominant language
- Python
- Stars
- 37
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from pyfar/sofar
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
invalid SOFA files for UTF-8 stringsPossibly taken @f-brinkmann claimed this 28 days ago. Openbug
Difficulty 3/5 1-2 days Newbie friendliness 55/100
-
[MAINT] Remove restrcition for Numpy 2.5Possibly taken @f-brinkmann claimed this 28 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 56/100
-
Move to h5netcdfMay be free again @hoyer-a claimed this 127 days ago, and no pull request is open. Openenhancement
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Kludex/python-multipart#375 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 3 days
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 11 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
FuRongJun-1999/dsh-memory#1000 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
gcivil-nyu-org/team5-mon-fall26#154 ·
Maintainers usually reply within 1 day