Assertions inside exceptions are silently not checked

Open
  • Is something wrong?
#82 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
65/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
python
Domain
testing-qa

Research direction

Start by reproducing the provided Pydantic ValidationError example in the pytest-examples plugin's handling of examples in docstrings and Markdown files. Trace how exception blocks and their assertions are evaluated; done means a test cannot pass when the expected exception is never raised, while existing valid examples continue to work.

Written by the indexing model from the issue text.

Description

e.g.:

from pydantic import BaseModel, ValidationError


class Model(BaseModel):
    num: complex


try:
    Model(num=complex(1))  # works
except ValidationError as exc:
    print(repr(exc.errors()[0]['type']))
    #> 'complex_type'

This will pass tests, because the exception was never raised. This happened several times in pydantic, where such code was indeed raising when writing, but behavior changed over time.

Dominant language
Python
Stars
181
Forks
29
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from pydantic/pytest-examples

All issues in pydantic/pytest-examples

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.