Support tags

Open
  • Is something wrong?
#18 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
rust
Domain
observability

Research direction

Start by locating the Rust macro definitions and reviewing how they currently accept positional arguments. Compare the supported tag behavior in the Python SDK, then determine how the optional tags argument should be handled for spans and logs. Done means the macros accept tags without breaking existing calls and the relevant behavior is covered by tests.

Written by the indexing model from the issue text.

Description

The logfire Python SDK supports adding tags to spans and logs. We should update our macros to have an optional tags: [tags] argument (probably before the positional ones).

Dominant language
Rust
Stars
78
Forks
13
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from pydantic/logfire-rust

All issues in pydantic/logfire-rust

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.