Allow the stylesheets ngp resolves outside the project root in `server.fs.allow`

Open
#40 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
50/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
angular, typescript, vite

Research direction

Read the handling for component stylesheets loaded as <file>.scss?inline and the code that sets server.fs.allow to the workspace root. Start by tracing which resource directories ngp resolves and how Vite checks allowed paths. Done means those resolved directories are allowed, including styles in shared libraries outside the project root.

Written by the indexing model from the issue text.

Description

feature

Part of #27.

Problem

ngp loads component stylesheets as <file>.scss?inline through Vite, which refuses files outside server.fs.allow ("Denied ID"). In a monorepo, shared libraries' styles live outside the project root.

Proposed change

Allow the directories of the resources ngp resolves. We set server.fs.allow to the workspace root today.

Setup: ngp 0.3.0, @angular/compiler/compiler-cli 22.3.0-next.4, Vite 8, Vitest 5.1.0 (pool: 'forks'), a Nx monorepo with 1,035 Angular projects, one Vitest config each, specs written for TestBed under JIT (Analog).

Dominant language
TypeScript
Stars
7
Forks
1
Avg merge
12h 24m
Merged PRs (30d)
13

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from push-based/vite-plugin-ngp

All issues in push-based/vite-plugin-ngp

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.