Data.List.NonEmpty.intersect and Data.List.NonEmpty.intersectBy throw when intersection empty
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 1/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Domain
- backend
Research direction
Start by comparing Data.List.NonEmpty.intersect and intersectBy with the corresponding NonEmptyArray functions, as the issue suggests. Review the discussion in #184 and the linked pull request #217 before deciding what outcome is intended. Done means the intersection functions handle empty results consistently with the chosen API direction.
Written by the indexing model from the issue text.
Description
I think they should be changed to match the implementation of the corresponding functions in NonEmptyArray, i.e. return a List instead of a NonEmptyList.
Alternatively, I saw the discussion in #184 about potentially removing the set functions from Array, List, NonEmptyList, NonEmptyArray, etc. and replacing them with an ordered set type. This might be more evidence supporting those who want to remove them.
- Dominant language
- PureScript
- Stars
- 61
- Forks
- 50
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 1
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from purescript/purescript-lists
-
ZipList is BindOpen
Difficulty 4/5 3-5 days Newbie friendliness 35/100
purescript/purescript-lists#219 · 1 comment · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
purescript/purescript-lists#218 ·
-
type: enhancement
Difficulty 4/5 3-5 days Newbie friendliness 25/100
purescript/purescript-lists#197 · 1 comment ·
-
type: enhancement
Difficulty 5/5 Over a week Newbie friendliness 24/100
purescript/purescript-lists#194 · 5 comments ·
-
type: enhancement
Difficulty 4/5 3-5 days Newbie friendliness 35/100
purescript/purescript-lists#192 · 4 comments · 1 reaction ·
All issues in purescript/purescript-lists
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
milind-soni/OpenMausBot#5829 ·
Maintainers usually reply within 1 day