Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

A task input for its package's locked dependencies, so a lockfile edit misses only the tasks whose dependencies moved

Aberta
  • Algo errado?
#876 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
5/5
Tempo estimado
Mais de uma semana
Facilidade para iniciantes
28/100
Tipo de issue
Funcionalidade
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
rust, yaml
Domínio
build-system, tooling

Direção de pesquisa

Start with the cache input handling and lockfile parsing paths; the issue does not name source files or tests, so locate those entry points first. Read the existing input documentation and inspect how task fingerprints are built, then trace how workspace lockfile entries represent transitive, peer-qualified, optional, and workspace dependencies. Done means a declared input hashes only the task package's resolved dependency closure and fails when a required lockfile entry is missing.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Written by an AI agent (Claude) on behalf of @jasonkuhrt.

Summary

A cached task cannot say "I depend on my package's installed dependencies" in a way that is both correct and stable. Each setting available today either replays a stale result or misses for a change the task never depended on.

This asks for one more input kind: a hash of the task's own package's resolved dependency closure, read from the lockfile. Turborepo has the same thing as each task's external_deps_hash.

What happens today

Two packages. a depends on is-odd through the catalog, and b depends on left-pad.

# pnpm-workspace.yaml
packages:
  - packages/*
catalog:
  is-odd: 3.0.1

// packages/a/package.json
{ "name": "a", "type": "module", "dependencies": { "is-odd": "catalog:" } }
// packages/b/package.json
{ "name": "b", "type": "module", "dependencies": { "left-pad": "1.3.0" } }

// packages/a/build.mjs
import isOdd from 'is-odd';
console.log('a built', isOdd(3));

// packages/a/vite.config.ts
import { defineConfig } from 'vite-plus';

export default defineConfig({
  run: {
    tasks: {
      build: { command: 'node build.mjs', cache: { input: INPUT } },
      check: { command: 'vp lint build.mjs', cache: { input: [{ auto: true }] } },
    },
  },
});

Each run below starts from a warm cache, then makes one change and runs vp install (vp 1.3.0, pnpm 10.18.0, macOS):

INPUT Change Result
[{ auto: true }], the default vp install --force, which changes nothing check: cache miss: 'node_modules/.modules.yaml' modified
[{ auto: true }, '!node_modules/**'], the docs' example catalog is-odd: 3.0.1 → 2.0.0 build: cache hit, replaying output built against is-odd 3.0.1
the docs' example plus { pattern: 'pnpm-lock.yaml', base: 'workspace' } b's left-pad 1.3.0 → 1.2.0 build: cache miss: 'pnpm-lock.yaml' modified
  • Default: tracking is exact for a plain script: build replays after b's bump and misses after a's. But any command that loads a config reads pnpm's install metadata, so it misses after every reinstall (voidzero-dev/vite-plus#2845).
  • Excluding node_modules: this takes dependencies out of the key entirely. A task's fingerprint is its cwd, program, args and envs (SpawnFingerprint), with no dependency component.
  • Naming the lockfile: this puts dependencies back, but as one file for the whole workspace. Every task that names it misses on every lockfile edit.

In our monorepo (138 packages), build-like tasks use the third setting. Over one week, 2,011 of the 4,673 misses whose reason was pnpm-lock.yaml (43%) were for packages whose resolved dependencies had not changed.

Proposal

A declared input whose content is the task's package's resolved dependency closure. Shape and name are yours to pick; for example:

cache: { input: [{ auto: true }, '!node_modules/**', { dependencies: 'locked' }] }

The closure is what the package's lockfile entry reaches:

  • each dependency's specifier and resolved version;
  • transitively, every resolved package those reach, including peer-qualified variants and optional dependencies;
  • workspace dependencies, followed through their own lockfile entries;
  • the catalog, override and patch entries that reach any of them.

With that input, b's bump replays a's build and the catalog bump misses it. A lockfile entry the closure needs but cannot find should fail the run, not silently hash less.

Prior art
  • Turborepo adds external_deps_hash to each task's hash (turborepo-hash). It computes the value from per-package closures (all_transitive_closures) for npm, pnpm, Yarn and Bun lockfiles.
  • Nx hashes the versions of the external packages a project's source imports, and its externalDependencies input adds the tools a command runs (docs).
How we work around it

We built this outside Vite Task:

  1. A pnpm-lock.yaml parser computes each package's closure by the rules above.
  2. A root task writes one hash file per package.
  3. Each task depends on that root task and declares its own package's hash file as an input.

It works, but every consumer needs an extra dependency edge, and every workspace that wants this has to re-implement the lockfile's semantics. We're happy to share the closure rules, or to open a PR if you want this approach.

Linguagem predominante
Rust
Estrelas
480
Forks
50
Merge médio
1d 5h
PRs com merge (30d)
65

Preparar o ambiente

Abrir no Codespaces

Inicia o contêiner de desenvolvimento do projeto no navegador, com a sua própria conta do GitHub.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de voidzero-dev/vite-task

Todas as issues de voidzero-dev/vite-task

Issues semelhantes

Mais issues de Rust

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.