Allow certificate lifetimes to be given in d,mo,y as well as hours.

Aberta
  • Algo errado?
#1,182 0 comentários 2 reações 1 responsável Ver no GitHub

Mantenedores costumam responder em até 1 dia

@hslatman já está trabalhando nisso.

Desde 4/6/2024.

Avaliação

Esta issue ainda não foi avaliada.

Descrição

enhancement needs triage

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Currently, certificate lifetimes can only be given in hours, minutes and seconds. If you want to create a cert with a 90 day life, you cant say --not-after 90d but instead have to put --not-after 2160h

We should be able to use time periods in days or years; months might be awkward as they are different lengths and the 'm' would clash with 'minutes' but maybe '1M' could mean '30d'?

I would like to be able to use time windows such as

  • --not-after 1y
  • --not-after 90d
  • --not-after 3mo (this one I could live without though)

Why is this needed?

This is a relatively simple change that would be a bit improvement on usability when creating longer-lived certificates such as for hosts and services, which typically want to live for 90 days or 1 year. Giving longer times in hours is confusing and error-prone.

Linguagem predominante
Go
Estrelas
4.3k
Forks
320
Merge médio
2d 3h
PRs com merge (30d)
11

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de smallstep/cli

Todas as issues de smallstep/cli

Issues semelhantes

Mais issues de Go

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.