[iOS, Fabric] measureInWindow stays off by the page sheet shrink offset after the sheet is dismissed

Aberta
  • Algo errado?
#59,171 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 2 dias

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
45/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
ios, react-native
Domínio
mobile

Direção de pesquisa

Start with the mandatory reproducer and compare its measurements before and after dismissing a page sheet; the plain React Native 0.88.0 run did not reproduce the issue. Then trace how Fabric's hosting view gets its window origin during layout on iOS. Done means reproducing and fixing the stale measurement in the reported navigation setup, with the value returning to its original y after dismissal.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Update: minimal app result. In a plain React Native 0.88.0 app on an iOS 27.0 simulator (iPhone 17, Modal pageSheet, no navigation library), the value stayed y=80 before and after the sheet was dismissed. The original report came from an app that uses react-native-screens 4.30.0 with a native stack, so the effect may depend on that navigation setup or on the device. The steps below are the original report.

Description

On iOS with Fabric, after a native page sheet (presentationStyle pageSheet) is presented and then dismissed, measureInWindow stays off by the shrink offset of the presenting screen. We measured 20 pt and 68 pt on an iPhone Air in portrait. The values are correct again after a layout of the root view, for example a rotation.

Likely cause (our reading): UIKit applies a transform to the presenting screen while the sheet is up. The surface hosting view takes its window origin from its frame in the window during layout, including that transform. After dismissal the transform is removed but the hosting view is not laid out again.

Related, different case: #58981 (centered formSheet on iPad, window inset missing from measureInWindow).

Steps to reproduce
  1. Render a View and call measureInWindow on it. Note the y value.
  2. Present a Modal with presentationStyle pageSheet, then dismiss it.
  3. Call measureInWindow again on the same view. Expected: the same y. Observed: y is off by the shrink offset.
  4. Rotate the device and measure again. The values are correct.
React Native Version

0.88.0 (Expo SDK 58.0.14, react-native-screens 4.30.0 in the app)

Affected Platforms

iOS

Output of npx @react-native-community/cli info

Not captured. The reproducer has not been run yet.

Stacktrace or Logs

None. The values are wrong without an error.

MANDATORY Reproducer

https://github.com/Acetyld/rn-measure-page-sheet-repro

Run result: in a plain RN 0.88.0 app on an iOS 27.0 simulator, the value stayed y=80 before and after the sheet. The effect may depend on the navigation setup or device.

Screenshots and Videos

None yet.

Linguagem predominante
C++
Estrelas
127k
Forks
25.5k
Merge médio
3d 18h
PRs com merge (30d)
188

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de react/react-native

Todas as issues de react/react-native

Issues semelhantes

Mais issues de C++

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.