Able to edit time in TextInput to non intervals when the minuteInterval is set.

Aberta
  • Algo errado?
#806 0 comentários 0 reações 0 responsáveis Ver no GitHub

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
48/100
Tipo de issue
Funcionalidade
Clareza
Razoavelmente clara
Status de atividade
Estagnada
Stack de tecnologia
ios, javascript, react-native
Domínio
mobile

Direção de pesquisa

Start by reading the iOS DateTimePicker implementation and its handling of minuteInterval and TextInputMode; the issue does not name specific files or tests. Check how UIDatePicker's roundsToMinuteInterval option affects keyboard entry, then identify the public API and tests that would need to cover the new boolean parameter. Done means keyboard entry can preserve non-interval minutes while the spinner retains the configured interval.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Feature request

Hi Team, I've been using minuteInterval set to 15mins in DateTimePicker. But the requirement here is to show the timer picker with 15-minute intervals in the spinner and the user should be able to edit non-15-minute intervals while using the keyboard.
We can achieve this feature on iOS datetimepicker just by making the roundsToMinuteInterval param false.
ref: https://developer.apple.com/documentation/uikit/uidatepicker/3791478-roundstominuteinterval?language=objc

Why it is needed

So after adding minuteInterval={15}, we were able to see the time picker with 15-minute intervals in the spinner but the problem was when we used the keyboard the time would round to the closest 15min closest. The change we want is to prevent the time picker from going back to the closest 15mins interval while using the keyboard I mean when the picker is in TextInputMode the user can enter 15-minute intervals while using the keyboard.

Possible implementation

Adding an extra parameter roundsToMinuteInterva which takes bool as a param.

sample

https://github.com/react-native-datetimepicker/datetimepicker/assets/115147840/b8c84f57-a32d-4490-87cc-49d8d5548cb1

Linguagem predominante
JavaScript
Estrelas
2.9k
Forks
459
Merge médio
4d 16h
PRs com merge (30d)
5

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de react-native-datetimepicker/datetimepicker

Todas as issues de react-native-datetimepicker/datetimepicker

Issues semelhantes

Mais issues de JavaScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.