Load the helper files through Composer autoload instead of a boot stage
Mantenedores costumam responder em até 1 dia
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 3/5
- Tempo estimado
- 1-2 dias
- Facilidade para iniciantes
- 52/100
Direção de pesquisa
Start with composer.json (add the 30 helper paths under autoload.files) and LoadHelpersStage, which currently globs src/*/Helpers and runs require_once on each file; keep only the application and module helper loading there. Add a test that compares the files in src/*/Helpers with the autoload.files list in both directions, then run composer dump-autoload and the test suite. Done when every helper is callable after vendor/autoload.php, the boot no longer scans src/*/Helpers, and the CI checks pass.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Summary
Declare the framework's 30 helper files in autoload.files of composer.json, and stop scanning for them in LoadHelpersStage.
Why
LoadHelpersStagefinds the component helpers on every boot: it scanssrc/*/Helperswithgloband runsrequire_onceon each file. The rootcomposer.jsonhas nofilesentry today.- The helper files are plain function definitions. They have no constants and no code that runs when the file is included, and only two files have guards (the
cron_*functions and thegetallheaderspolyfill), which is the shape Composerfilesexpects. - A static list from Composer replaces about 26 directory scans on every boot, and tools such as PHPStan and IDEs see the functions without booting the application.
- The packages are to be extracted into separate Composer packages from 4.0, each with its own
composer.jsonand its own helpers. If the helpers are already declared withautoload.filesin the monorepo, extraction only moves each package's list into its owncomposer.json.
Scope
- Add the 30 helper files (26 packages:
Apphas 4,Environmenthas 2, every other package has 1) toautoload.filesincomposer.json. - Remove the component part of
LoadHelpersStage. It keeps loading the application'shelpers/and each module'shelpers/, which are the application's own files. - Add a test that fails when a file in
src/*/Helpersis not listed inautoload.files, or when a listed file does not exist. Without it, a new helper file that is not added tocomposer.jsonshows up only as "undefined function". - Update the documentation that describes helper loading at boot (the App architecture page) when this is released.
Notes
- The helpers become available as soon as
vendor/autoload.phpis included, not at boot. They useDSonly inside function bodies, so loading earlier is safe. - Adding a helper file needs an entry in
composer.jsonand acomposer dump-autoload, instead of being picked up by the scan. - When a package is later extracted, the paths in its list may change if its folder layout differs from
src/<Package>/Helpers/.
Out of scope
- Extracting any package.
- Loading the application's and the modules' helpers.
- Changing what any helper function does.
Acceptance criteria
- every helper function is available right after
vendor/autoload.php, without booting the application - the boot no longer scans
src/*/Helpers - the application's and the modules' helpers still load, in the same order after the framework's
- the new test fails for an unlisted helper file
composer test,composer cs:check,composer phpstanandcomposer rector:checkpass on every PHP version in the CI matrix
- Linguagem predominante
- PHP
- Estrelas
- 43
- Forks
- 22
- Merge médio
- 54min
- PRs com merge (30d)
- 57
Preparar o ambiente
- Sem Dockerfile nem arquivo Docker Compose
- Sem modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de quantum-php/framework
-
bug good first issue
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
quantum-php/framework#692 ·
Mantenedores costumam responder em até 1 dia
-
routing testing
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 76/100
quantum-php/framework#547 ·
Mantenedores costumam responder em até 1 dia
-
bug
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 72/100
quantum-php/framework#694 ·
Mantenedores costumam responder em até 1 dia
-
Raise PHPStan to level 9Abertarefactoring tech debt
Dificuldade 5/5 Mais de uma semana Facilidade para iniciantes 20/100
quantum-php/framework#693 ·
Mantenedores costumam responder em até 1 dia
-
install:debugbar reads the package folder from the working directory and uses the default storage adapterTalvez já em andamento @armanist assumiu hoje. Abertabug console debugbar good first issue
quantum-php/framework#691 · 1 responsável ·
Mantenedores costumam responder em até 1 dia
Todas as issues de quantum-php/framework
Issues semelhantes
-
35-feedback
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
Mantenedores costumam responder em até 1 dia
-
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 70/100
ajeetraina/awesome-docker-sbx#559 ·
-
PHP 8.6 supportAberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 68/100
-
Saisie des adressesAberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 62/100
pantaflex44/Tiquettes#116 · 1 comentário ·
-
dependencies enhancement
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 68/100
novalo-dev/Prestashop-MCP-Server#329 ·
Mantenedores costumam responder em até 1 dia