Support moving and renaming a module with a file destination

Aberta
  • Algo errado?
#917 1 comentário 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 7 dias

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
5/5
Tempo estimado
Mais de uma semana
Facilidade para iniciantes
38/100
Tipo de issue
Funcionalidade
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
python
Domínio
devtools

Direção de pesquisa

Start by reading MoveModule.get_changes() and the existing move and rename refactorings to determine whether composing them already supports this workflow. If extending MoveModule, define destination and collision semantics, then cover normal, from, aliased, relative, and in-module imports with regression tests. Done means renamed file destinations rewrite imports consistently; assess the separate find_relative_module() change with its own reproducer and test.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Proposal

Consider extending MoveModule.get_changes() to accept a destination file, so callers can move and rename a module in one refactoring, for example:

old_package/module.py → new_package/renamed.py

Currently, MoveModule requires a folder destination. Commit https://github.com/python-rope/rope/commit/e7bfd4f5f4cb798f5b96ba7111e07e16254958f7 experiments with accepting file destinations and adjusting import rewriting. The feature idea seems worth considering, but the patch needs further work rather than merging unchanged.

Suggested scope

  • Define destination-file semantics, including whether the file must not yet exist, collision handling, and how package moves differ from module moves.
  • Update import rewriting consistently for both unchanged and renamed module basenames. The experimental patch's special case for from old_package import module only handles a destination with the same basename.
  • Cover normal imports, from-imports, aliases, relative imports, and imports inside the moved module with regression tests.
  • Avoid the patch's broad except Exception handler, which hides the underlying failure.

First assess whether composing the existing move and rename refactorings already provides this behaviour reliably. If so, a convenience API or documentation may be preferable to extending MoveModule.

Separate concern

The same commit changes find_relative_module() to fall back to the project root when folder is false. That change should not be included without a separate reproducer and regression test establishing the intended relative-import behaviour.

This suggestion is based on source review of the commit and the current implementation, not behavioural testing of the patch.

Linguagem predominante
Python
Estrelas
2.2k
Forks
197
Merge médio
2d 13h
PRs com merge (30d)
5

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de python-rope/rope

Todas as issues de python-rope/rope

Issues semelhantes

Mais issues de Python

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.