Per-instance config identity defeats the resolved-style cache (2307 entries where 417 suffice)
Mantenedores costumam responder em até 3 dias
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 3/5
- Tempo estimado
- 1-2 dias
- Facilidade para iniciantes
- 45/100
- Tipo de issue
- Bug
- Clareza
- Claramente especificada
- Status de atividade
- Pouca atividade
- Stack de tecnologia
- react-native, typescript
- Domínio
- mobile, performance
Direção de pesquisa
Start in src/native/api.tsx, comparing the module-scope mappingToConfig(mapping) in styled() with the per-instance useState call in useCssElement(), then check the identity-based cache key in src/native/react/rules.ts. Read src/components/View.tsx to see how the shipped wrappers pass a constant mapping. Done when repeated identical elements no longer add stylesFamily entries, and the existing native style tests still pass.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Before submitting a new issue
- I tested using the latest version of the library, as the bug might be already fixed.
- I tested using a supported version of react native.
- I checked for possible duplicate issues, with possible answers.
Bug summary
useCssElement derives its style config per component instance, but the resolved-style cache is keyed on that config's object identity. Every shipped components/*.tsx wrapper passes a module-constant mapping, so N mounted elements produce N distinct config identities carrying identical values, and N identical elements each get their own stylesFamily entry, their own sorted rule array and their own observable, where one would do. styled() derives its config once at module scope and shares one entry.
The cache key (src/native/react/rules.ts) hashes the config by identity, through a weakFamily that numbers each new object:
const keys = [state.configs, ...iterableKeys];
The two entry points in src/native/api.tsx derive it differently:
// line 53, styled(): once, at module scope
const configs = mappingToConfig(mapping);
// line 89, useCssElement(): once per instance
const [config] = useState(() => mappingToConfig(mapping));
and every shipped wrapper takes the second path with a module-constant mapping (src/components/View.tsx):
const mapping = {
className: "style",
} satisfies StyledConfiguration<typeof RNView>;
// ...
return useCssElement(RNView, props, mapping);
mappingToConfig is pure in mapping, so it returns the same value and a new identity on every call.
On a screen of 150 identical controls, four styled elements each plus the surrounding chrome, in a release build of React Native 0.86 with Fabric and Hermes on an iPhone 12 Pro Max with iOS 26.6, 3.0.7 held 2307 entries, and 417 with mappingToConfig memoised on the mapping; 417 is the floor of a screen with many distinct class lists. A Mi MIX 3 with 150 identical radio controls held 1785, and 270 with #434. Rendered output is the same either way; the cost is the work and the retained objects. One Instruments CPU run per side over a 160-instance scene put the JS thread at 2914 ms against 2794 ms and 2129 ms against 2082 ms, inside my suite's run-to-run spread, so I can claim no CPU win from my own workload.
#434 fixes it, with these tests.
Library version
main at 2421ea7 (0.0.0-nightly.2421ea7), and 3.0.7
Environment info
System:
OS: Windows 11 10.0.26300
CPU: "(32) x64 AMD Ryzen 9 9950X3D 16-Core Processor "
Memory: 155.26 GB / 255.67 GB
Binaries:
Node:
version: 26.12.1
path: C:\Program Files\nodejs\node.EXE
Yarn:
version: 4.9.2
path: C:\Users\<user>\AppData\Roaming\npm\yarn.CMD
npm:
version: 12.2.1
path: C:\Program Files\nodejs\npm.CMD
Watchman: Not Found
SDKs:
Android SDK:
API Levels:
- "33"
- "35"
- "35"
- "35"
- "36"
- "37"
Build Tools:
- 35.0.0
- 36.0.0
- 36.1.0
- 37.0.0
System Images:
- android-26 | Google APIs Intel x86_64 Atom
- android-28 | Google APIs Intel x86_64 Atom
- android-29 | Google APIs Intel x86_64 Atom
- android-30 | Google APIs Intel x86_64 Atom
- android-31 | Google APIs Intel x86_64 Atom
- android-32 | Google APIs Intel x86_64 Atom
- android-33 | Google APIs Intel x86_64 Atom
- android-34 | Google APIs Intel x86_64 Atom
- android-35 | Google APIs Intel x86_64 Atom
- android-36.1 | Google Play Intel x86_64 Atom
- android-36.1 | Pre-Release 16 KB Page Size Google Play Intel x86_64 Atom
- android-37.0 | Google APIs Intel x86_64 Atom
Android NDK: Not Found
Windows SDK: Not Found
IDEs:
Android Studio: AI-262.9437.185.2621.16467767
Visual Studio: Not Found
Languages:
Java:
version: 17.0.20.1
path: C:\Program Files\Microsoft\jdk-17.0.20.101-hotspot\bin\javac.EXE
Ruby: Not Found
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 19.2.3
wanted: 19.2.3
react-native:
installed: 0.86.3
wanted: 0.86.3
react-native-windows: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: Not found
newArchEnabled: Not found
iOS:
hermesEnabled: Not found
newArchEnabled: Not found
Steps to reproduce
stylesFamily exposes no count on main, so the reproducer branch is main at 2421ea7 with family() given a size(), and one test added, src/__tests__/native/style-cache-per-instance.test.tsx.
- Clone the reproducer branch and install:
git clone --branch repro/433-per-instance-config-identity https://github.com/YevheniiKotyrlo/react-native-css cd react-native-css yarn install - Run
yarn jest src/__tests__/native/style-cache-per-instance.test.tsx.
src/native/reactivity.ts:
diff --git a/src/native/reactivity.ts b/src/native/reactivity.ts
index a32ac64..ad4309c 100644
--- a/src/native/reactivity.ts
+++ b/src/native/reactivity.ts
@@ -173,6 +173,9 @@ export function family<Key, Result = Key, Args extends any = void>(
delete(key: Key) {
return map.delete(key);
},
+ size() {
+ return map.size;
+ },
clear() {
return map.clear();
},
src/__tests__/native/style-cache-per-instance.test.tsx:
// The resolved-style cache holds one entry per distinct class list, so 50 identical elements resolve one style set
import { View as RNView } from "react-native";
import { render } from "@testing-library/react-native";
import { View } from "react-native-css/components/View";
import { registerCSS } from "react-native-css/jest";
import { styled } from "react-native-css/native";
import { stylesFamily } from "../../native/styles";
const StyledView = styled(RNView, { className: { target: "style" } });
test.each([
["View", View],
["styled(View)", StyledView],
])(
"50 identical %s elements hold one resolved-style cache entry",
(_name, Component) => {
registerCSS(`.probe { color: red; width: 10px; }`);
stylesFamily.clear();
render(
<>
{Array.from({ length: 50 }, (_unused, index) => (
<Component key={index} className="probe" />
))}
</>,
);
expect(stylesFamily.size()).toBe(1);
},
);
Expected: 50 identical elements hold one resolved-style cache entry, through the shipped View as through styled(View).
Actual: the shipped View holds 50, one per element, and styled(View) holds one.
The run's output on main at 2421ea7, Windows 11, Node 26.12.1
FAIL src/__tests__/native/style-cache-per-instance.test.tsx (8.787 s)
× 50 identical View elements hold one resolved-style cache entry (26 ms)
√ 50 identical styled(View) elements hold one resolved-style cache entry (6 ms)
● 50 identical View elements hold one resolved-style cache entry
expect(received).toBe(expected) // Object.is equality
Expected: 1
Received: 50
28 | );
29 |
> 30 | expect(stylesFamily.size()).toBe(1);
| ^
31 | },
32 | );
33 |
at toBe (src/__tests__/native/style-cache-per-instance.test.tsx:30:33)
Test Suites: 1 failed, 1 total
Tests: 1 failed, 1 passed, 2 total
Snapshots: 0 total
Time: 9.86 s
Ran all test suites matching /src\\__tests__\\native\\style-cache-per-instance.test.tsx/i.
Reproducible example repository
https://github.com/YevheniiKotyrlo/react-native-css/tree/repro/433-per-instance-config-identity
- Linguagem predominante
- TypeScript
- Estrelas
- 166
- Forks
- 45
- Merge médio
- 13d 14h
- PRs com merge (30d)
- 1
Preparar o ambiente
- Sem Dockerfile nem arquivo Docker Compose
- Sem modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de nativewind/react-native-css
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
nativewind/react-native-css#545 ·
Mantenedores costumam responder em até 3 dias
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
nativewind/react-native-css#544 ·
Mantenedores costumam responder em até 3 dias
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
nativewind/react-native-css#543 ·
Mantenedores costumam responder em até 3 dias
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 84/100
nativewind/react-native-css#540 ·
Mantenedores costumam responder em até 3 dias
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
nativewind/react-native-css#538 ·
Mantenedores costumam responder em até 3 dias
Todas as issues de nativewind/react-native-css
Issues semelhantes
-
fix(worker): keep normal prepare waiting states failure-freeTalvez já em andamento @LichKing-2234 assumiu hoje. Abertaagent:codex priority:P1
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
AgoraIO-Extensions/agent-infra#3745 ·
Mantenedores costumam responder em até 1 dia
-
The five-line work window can drop its oldest line: the per-line byte share ignores the JSON framingTalvez já em andamento @Eapp1e assumiu hoje. Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 84/100
makecindy/cindy#7973 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 78/100
lingdojo/kana-dojo#33337 · 1 comentário · 5 reações ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 76/100
coder/xum#7733 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
code-yeongyu/senpi#4917 · 1 comentário ·
Mantenedores costumam responder em até 1 dia