[v2] createMcpHandler legacy fallback misses an abort that happens before it subscribes

Aberta Para iniciantes
  • Algo errado?
#3,136 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

@mariano-aguero já está trabalhando nisso.

Desde 30/10/2026.

  • #3137 de @mariano-aguero — aberto

Avaliação

Dificuldade
2/5
Tempo estimado
1-3 horas
Facilidade para iniciantes
82/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
typescript
Domínio
backend-api-design

Direção de pesquisa

Comece em packages/server/src/server/createMcpHandler.ts, em createLegacyStatelessFallback, por volta das linhas citadas 342–360, e compare o tratamento de cancelamentos com PerRequestHTTPServerTransport.handleMessage. O issue descreve a falha e uma possível correção; considera-se concluído quando uma requisição cancelada antes da inscrição encerra o transport e cancela ctx.mcpReq.signal, assim como uma cancelada depois.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

v2
What happened?

In the legacy stateless fallback of createMcpHandler, a request whose client aborts before the handler subscribes to request.signal is never seen as aborted. The tool runs with a ctx.mcpReq.signal that never fires, and the transport and server built for that request are only torn down when the tool finishes.

createLegacyStatelessFallback awaits factory() and product.connect(transport), and only then calls request.signal?.addEventListener('abort', teardown, { once: true }). An abort event that already fired is not delivered to a listener added later, and nothing checks request.signal.aborted after subscribing:

https://github.com/modelcontextprotocol/typescript-sdk/blob/39ae8e6192cf43273aaaf2de4169dfa9f7216e28/packages/server/src/server/createMcpHandler.ts#L342-L360

We hit it on a server whose tool waits up to 45 s for a state change and stops early on ctx.mcpReq.signal. A client that dropped the request while auth and the factory were still running left that wait running to its end. On a loaded machine that window was a few hundred ms. Our workaround is to also listen on ctx.http.req.signal in the tool.

What did you expect?

A request aborted before the handler subscribed is handled like one aborted after: teardown runs, the transport closes and ctx.mcpReq.signal aborts. The modern path already does this, since PerRequestHTTPServerTransport.handleMessage checks signal.aborted before dispatching.

A possible fix is to check right after subscribing:

request.signal?.addEventListener('abort', teardown, { once: true });
if (request.signal?.aborted) teardown();
Code to reproduce
import { createMcpHandler, McpServer } from '@modelcontextprotocol/server';

const handler = createMcpHandler(() => {
  const server = new McpServer({ name: 'repro', version: '0.0.0' });
  server.registerTool('wait', { description: 'Waits up to 2 s for the request to be aborted' }, async (ctx) => {
    const started = Date.now();
    const aborted = await new Promise((resolve) => {
      if (ctx.mcpReq.signal.aborted) return resolve(true);
      ctx.mcpReq.signal.addEventListener('abort', () => resolve(true), { once: true });
      setTimeout(() => resolve(false), 2_000);
    });
    console.log(`tool saw the abort: ${aborted}, after ${Date.now() - started} ms`);
    return { content: [{ type: 'text', text: 'done' }] };
  });
  return server;
});

async function call(signal) {
  const request = new Request('http://localhost/mcp', {
    method: 'POST',
    headers: { 'content-type': 'application/json', accept: 'application/json, text/event-stream' },
    body: JSON.stringify({ jsonrpc: '2.0', id: 1, method: 'tools/call', params: { name: 'wait', arguments: {} } }),
    signal,
  });
  // Held for the whole exchange, as a server framework holds it.
  await handler.fetch(request).then((res) => res.text(), () => undefined);
  return request;
}

console.log('client aborts 1 s into the call:');
const late = new AbortController();
setTimeout(() => late.abort(), 1_000);
await call(late.signal);

console.log('client aborted before the handler subscribed:');
await call(AbortSignal.abort());

Output with Node 22.11:

client aborts 1 s into the call:
tool saw the abort: true, after 971 ms
client aborted before the handler subscribed:
tool saw the abort: false, after 2001 ms

The script keeps the Request alive until the response is read. Without that, undici can garbage-collect the original request and its signal stops reaching the clone that classifyEntryRequest forwards, so even the first case never sees the abort. That is unrelated to this issue.

SDK version

@modelcontextprotocol/server 2.3.1. The same code is on main at 39ae8e6 (2.4.0 was not tested).

Area

Server

Linguagem predominante
TypeScript
Estrelas
13.7k
Forks
2.4k
Merge médio
2d 7h
PRs com merge (30d)
26

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de modelcontextprotocol/typescript-sdk

Todas as issues de modelcontextprotocol/typescript-sdk

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.