typescript-go: Infinite recursion in inferFromTypes via getReturnTypeOfSignature (tsc 5.9 OK)
Mantenedores costumam responder em até 1 dia
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 5/5
- Tempo estimado
- Mais de uma semana
- Facilidade para iniciantes
- 12/100
- Tipo de issue
- Bug
- Clareza
- Razoavelmente clara
- Status de atividade
- Ativa
- Stack de tecnologia
- go, typescript
- Domínio
- compilers
Direção de pesquisa
Start from the stack in the issue: getReturnTypeOfSignature in the checker, then inferFromTypes and inferFromTypeArguments in inference.go (around lines 89-98 and 311), and fillMissingTypeArguments in checker.go. Reproduce with the linked repo (npx oxlint --type-aware src) and api-probe.cjs. Done means the recursion terminates, ideally by hitting an instantiation or depth limit, with tsc and tsgo agreeing on the result.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
🔎 Search Terms
Infinite Recursion, getReturnTypeOfSignature, IsEqual
🕗 Version & Regression Information
Versions
- typescript-go as bundled in
[email protected](also 0.24.0, 0.25.0);@typescript/[email protected]fortsgo --noEmit - typescript 5.9.3 for comparison
- macOS arm64
⏯ Playground Link
https://github.com/jandolezal71/typescript-go-issue-64701-repro
💻 Code
Repro
https://github.com/jandolezal71/typescript-go-issue-64701-repro
npm i
npx tsc --noEmit # ok, ~1 s
npx oxlint --type-aware src # never finishes
package.json devDependencies: [email protected], [email protected], [email protected], [email protected], [email protected]
.oxlintrc.json
{"plugins":["typescript"],"categories":{"correctness":"off"},"rules":{"typescript/no-misused-promises":"error"}}
tsconfig.json
{"compilerOptions":{"target":"ES2022","module":"ESNext","moduleResolution":"Bundler","strict":true,"noEmit":true,"skipLibCheck":true},"include":["src"]}
src/repro.spec.ts
import type { Asyncify, IsEqual, PartialDeep } from 'type-fest';
import { expect, vi } from 'vitest';
type Fn = (...args: any) => any;
type FirstOverload<TFn extends Fn> = (...args: Parameters<TFn>) => ReturnType<TFn>;
type NextOverload<TFn extends Fn, TStack extends Fn> = (...args: Parameters<TStack & TFn>) => ReturnType<TStack & TFn>;
type SafeAsyncify<TFn extends Fn> = ReturnType<TFn> extends Promise<unknown> ? TFn : Asyncify<TFn>;
// Collects all overloads of TFn; recursion stops once the next overload equals the previous one.
type PromisifyInner<TFn extends Fn, TAcc extends Fn, TStack extends Fn, TPrevious extends Fn, TCurrent extends Fn = NextOverload<TFn, TStack>> =
IsEqual<TCurrent, TPrevious> extends true ? TAcc : PromisifyInner<TFn, TAcc & SafeAsyncify<TCurrent>, TCurrent & TStack, TCurrent>;
type Promisify<TFn extends Fn, TFirst extends Fn = FirstOverload<TFn>> = PromisifyInner<TFn, SafeAsyncify<TFirst>, TFirst, TFirst>;
type IfThenElse<C, T, F> = false extends C ? F : T;
type OwnProperties<T> = { [K in keyof T]: T[K] };
type AddOptionalRequestOptions<TFn> = TFn extends (...args: [...infer TArgs]) => infer TReturn
? ((...args: [...TArgs, requestOptions?: { timeout?: number }]) => TReturn) & TFn
: TFn;
type PromisifyProcedureTree<T> = T extends Fn
? ReturnType<T> extends Promise<unknown>
? AddOptionalRequestOptions<T>
: IfThenElse<
keyof OwnProperties<T> extends never ? true : false,
AddOptionalRequestOptions<Promisify<T>>,
AddOptionalRequestOptions<Promisify<T>> & PromisifyProcedureTree<OwnProperties<T>>
>
: T extends Record<string, unknown>
? { readonly [K in keyof T]: PromisifyProcedureTree<T[K]> }
: T;
type ProtocolValue = null | string | number | boolean | Date | readonly ProtocolValue[] | { readonly [key: string]: ProtocolValue };
type ProcedureTree<TProtocolValue> = {
readonly [key: string | number]:
| ProcedureTree<TProtocolValue>
| ((...args: never[]) => void | PartialDeep<TProtocolValue> | Promise<void | PartialDeep<TProtocolValue>>);
};
declare class Client<TTree> {
get call(): PromisifyProcedureTree<TTree>;
}
declare function createHandler<TTree extends ProcedureTree<ProtocolValue>>(): (client: Client<TTree>) => void;
expect(vi.mocked(createHandler)).toHaveBeenCalledTimes(1);
tsc API comparison (node api-probe.cjs, finishes in ~80 ms)
const ts = require('typescript');
const cfg = ts.getParsedCommandLineOfConfigFile('./tsconfig.json', {}, { ...ts.sys, onUnRecoverableConfigFileDiagnostic() {} });
const program = ts.createProgram(cfg.fileNames, cfg.options);
const checker = program.getTypeChecker();
const sf = program.getSourceFile('./src/repro.spec.ts');
let n = 0;
const t0 = Date.now();
(function visit(node) {
if (ts.isExpression(node)) {
const type = checker.getTypeAtLocation(node);
for (const part of type.isUnion() ? type.types : [type]) {
for (const sig of part.getCallSignatures()) { checker.getReturnTypeOfSignature(sig); n++; }
for (const prop of part.getProperties()) {
const pt = checker.getTypeOfSymbolAtLocation(prop, node);
for (const sig of pt.getCallSignatures()) { checker.getReturnTypeOfSignature(sig); n++; }
}
}
}
ts.forEachChild(node, visit);
})(sf);
console.log(`tsc ${ts.version} API: ${n} return types resolved in ${Date.now() - t0} ms`);
🙁 Actual behavior
Checker never terminates in getReturnTypeOfSignature (inference recursion) on overload-walking type; tsc 5.9 resolves it in milliseconds
What happens
checker.getReturnTypeOfSignaturenever returns: 100 % CPU indefinitely (observed >20 min).- It is reached through the type-aware linter tsgolint, rule
no-misused-promises(alsostrict-void-return). The rule only asks for the return type of a call signature. tsgo --noEmiton the same project finishes in ~1 s with no errors, because the plain check never requests this return type.
tsc 5.9.3 does not hang on the same requests
Through the TS API, I requested the return type of every call signature of every expression and its properties in the file. That is a superset of what the lint rule requests. All 1709 resolved in 79 ms (script below).
The type itself terminates
Forcing Promisify on concrete overloaded functions (1, 2 and 3 overloads, generic overloads) type-checks correctly in both tsc and tsgo. tsc reports 4174 instantiations.
Trigger
A recursive type walks function overloads and stops when IsEqual<Current, Previous> is true.
- With the type-fest 4.31+
IsEqual,<G>() => G extends A & G | G ? 1 : 2, it hangs. - With the older form,
<G>() => G extends A ? 1 : 2, it finishes in ~1 s.
All of these are needed to reproduce. Removing any one makes it finish:
- the recursive
PromisifyInner, - the
Clientclass with acallgetter, - the generic
createHandlerconstrained toProcedureTree, expect(vi.mocked(createHandler))(vitest'sMockedFunctiontype).
Stack (SIGQUIT on the hung process, trimmed; full dump attached as stack.txt):
tsgolint/internal/rules/no_misused_promises ...
typescript-go/internal/checker.(*Checker).getReturnTypeOfSignature
.instantiateType → .instantiateTypeWithAlias → .instantiateTypeWorker
.getConditionalTypeInstantiation → .getConditionalType
...458 frames elided...
.inferFromTypes (inference.go:89 / :98)
.inferFromTypeArguments (inference.go:311)
.inferFromTypes
.inferFromTypeArguments
... (repeats, same source/target pointers on each inferFromTypes call)
.fillMissingTypeArguments (checker.go:21859)
🙂 Expected behavior
Expected
The checker terminates like tsc does. If the type is too deep, it should report or bail out at the instantiation and depth limits, not loop.
Additional information about the issue
attaching stacktrace
- Linguagem predominante
- Go
- Estrelas
- 112k
- Forks
- 15.4k
- Merge médio
- 2d 21h
- PRs com merge (30d)
- 126
Preparar o ambiente
Inicia o contêiner de desenvolvimento do projeto no navegador, com a sua própria conta do GitHub.
- Sem Dockerfile nem arquivo Docker Compose
- Tem um modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de microsoft/TypeScript
-
Won't Fix
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 62/100
microsoft/TypeScript#65107 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
Native API: formatDiagnosticsWithColorAndContext drops related information without a file locationTalvez já em andamento @timurzvural assumiu hoje. Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
microsoft/TypeScript#65087 ·
Mantenedores costumam responder em até 1 dia
-
TS7 LSP: documentHighlight returns nothing when the file path contains '@'Talvez livre de novo Um pull request para esta issue foi fechado sem ser mesclado. AbertaBug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
microsoft/TypeScript#64758 ·
Mantenedores costumam responder em até 1 dia
-
Language server (tsc --lsp) exits with code 1 after `shutdown` and `exit`Talvez já em andamento @rajnish-verma-22172 assumiu há 13 dias. AbertaBug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 76/100
microsoft/TypeScript#64742 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
Class names `eval` and `arguments` are not reported as invalid strict mode bindingsTalvez já em andamento @dmety assumiu há 26 dias. AbertaBug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 68/100
microsoft/TypeScript#64661 ·
Mantenedores costumam responder em até 1 dia
Todas as issues de microsoft/TypeScript
Issues semelhantes
-
agent-butler-finding chore
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 78/100
jordansmall/spindrift#6318 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
Eyevinn/moqlivemock#166 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
JakeChampion/lang#14091 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 84/100
hyperledger/fabric-x-orderer#1409 ·
Mantenedores costumam responder em até 3 dias
-
get actions doesn't show the approval flag, and describe action shows it unformattedTalvez já em andamento @kenokech assumiu hoje. Abertabug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 82/100
Mantenedores costumam responder em até 1 dia