VB -> C#: Generic extension method inference widens element types when using a base-type comparer

Aberta
  • Algo errado?
#1,302 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 3 dias

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
55/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
csharp
Domínio
devtools, tooling

Direção de pesquisa

Start from the VB-to-C# conversion path for generic extension-method calls and reproduce the issue with the VB input in the report. Compare the generated Distinct call with the expected output; done means it specifies DerivedValue and preserves the declared return type.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

VB -> C#
VB.Net input code
Imports System.Collections.Generic
Imports System.Linq

Public Class BaseValue
    Public Property Key As Integer
End Class

Public Class DerivedValue
    Inherits BaseValue
End Class

Public Module Helpers
    Public Function ToDictionary(values As IEnumerable(Of DerivedValue)) As Dictionary(Of Integer, DerivedValue)
        Return values.Distinct(EqualityComparer(Of BaseValue).Default).ToDictionary(Function(value) value.Key)
    End Function
End Module
Erroneous output

The converted method leaves the generic arguments of Distinct implicit:

public static Dictionary<int, DerivedValue> ToDictionary(IEnumerable<DerivedValue> values)
{
    return values.Distinct(EqualityComparer<BaseValue>.Default).ToDictionary(value => value.Key);
}

C# infers BaseValue as the element type of Distinct, so ToDictionary returns Dictionary<int, BaseValue>.

This produces:

CS0029: Cannot implicitly convert type
'System.Collections.Generic.Dictionary<int, BaseValue>'
to 'System.Collections.Generic.Dictionary<int, DerivedValue>'
Expected output

The converter should preserve the type argument inferred by VB.NET:

public static Dictionary<int, DerivedValue> ToDictionary(IEnumerable<DerivedValue> values)
{
    return values.Distinct<DerivedValue>(EqualityComparer<BaseValue>.Default).ToDictionary(value => value.Key);
}
Details
  • Product: Visual Studio extension, built locally from master.
  • Version: 10.0.1 (local development build).
  • Previous working version: No.

VB.NET and C# use different type inference rules for generic extension methods.

VB.NET first infers the relevant type parameters from the receiver. In this example, it fixes the element type as DerivedValue. The base-type comparer is then accepted through the contravariance of IEqualityComparer(Of T).

C# inference considers both the receiver and the comparer, resulting in BaseValue instead. Omitting explicit type arguments therefore changes the type of the resulting sequence.

Microsoft's VB team describes this receiver-first inference here:
https://devblogs.microsoft.com/vbteam/extension-methods-and-generics-extension-methods-part-5/

A workaround is to specify the type argument explicitly in the VB source:

Return values.Distinct(Of DerivedValue)(EqualityComparer(Of BaseValue).Default).ToDictionary(Function(value) value.Key)
Linguagem predominante
C#
Estrelas
917
Forks
243
Merge médio
2d 15h
PRs com merge (30d)
9

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de icsharpcode/CodeConverter

Todas as issues de icsharpcode/CodeConverter

Issues semelhantes

Mais issues de C#

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.