Feature: allow review comments on any file line, not just lines within the diff
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 4/5
- Tempo estimado
- 3-5 dias
- Facilidade para iniciantes
- 48/100
Direção de pesquisa
Comece lendo os entry points add_comment_to_pending_review e pull_request_review_write e, em seguida, reproduza o workflow de revisão pendente descrito na issue com um comentário fora do diff. Rastreie como submit_pending trata esses comentários e como a mutação GraphQL addPullRequestReviewThread aceita path e line. Está concluído quando a falha for exposta ou os comentários em linhas arbitrárias de arquivos forem preservados inline, mantendo disponível a solução alternativa existente em nível de arquivo.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Describe the feature or problem you'd like to solve
When using add_comment_to_pending_review to leave a code review, the comment is silently dropped at submit time if the targeted line is outside the PR's diff hunks (e.g., unchanged context further up the file). The tool returns success on add_comment_to_pending_review, but pull_request_review_write { method: "submit_pending" } accepts the review without that comment ever appearing on the PR.
This means agents reviewing PRs cannot leave inline comments on file context that is relevant to a change but happens to sit outside the modified lines — for example, stale JSDoc on an exported interface that should be updated to reflect a new feature added several lines below.
In the GitHub web UI, a human reviewer can expand context and click any line in any file to add a comment. Agents using this MCP server cannot match that capability.
Proposed solution
Two parts:
-
Surface the failure. When a comment is dropped because the targeted line is outside the diff, return an error from
add_comment_to_pending_review(or surface it on submit) so the agent can fall back tosubjectType: "FILE"or a top-level comment. Today the tool reports success and the rejection happens silently inside GitHub's submit step. -
Support arbitrary file lines. Use the GraphQL
addPullRequestReviewThreadmutation (which acceptspath+linewithout requiring a diff position) when the requested line is outside the unified diff. This would give agent reviewers the same expressive power as human reviewers in the UI.
Example prompts or workflows (for tools/toolsets only)
- "Review this PR — flag any stale JSDoc/comments on exported APIs whose contract changed." Today the agent can correctly identify stale documentation but cannot leave the inline comment if the JSDoc itself isn't in the diff.
- "Suggest renames for the helper functions used by the new code." If the helpers themselves are unchanged, the agent can't comment on them inline.
- "Note any security-relevant invariants the changes rely on." Often these are documented elsewhere in the file, outside the diff.
Additional context
Repro:
- Open any PR with a small, localized diff.
- Use
pull_request_review_write { method: "create" }to start a pending review. - Use
add_comment_to_pending_reviewtargeting an unchanged line ≥30 lines from the diff. Tool returns success. - Use
pull_request_review_write { method: "submit_pending" }. Review submits without the comment. - Verify on the PR — the comment is missing.
Workaround today: use subjectType: "FILE" for file-level comments, or post a top-level issue comment with a permalink. Both lose the inline-thread experience.
Related but distinct: #1748 (fork-PR auth scope) — same symptom (comment doesn't post) but a different root cause.
- Linguagem predominante
- Go
- Estrelas
- 33.1k
- Forks
- 5k
- Merge médio
- 2d 1h
- PRs com merge (30d)
- 25
Guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de github/github-mcp-server
-
bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 84/100
github/github-mcp-server#3235 ·
-
enhancement
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 88/100
github/github-mcp-server#3042 · 2 comentários ·
-
bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
github/github-mcp-server#3032 · 1 reação ·
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 74/100
github/github-mcp-server#2803 · 1 comentário ·
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 76/100
github/github-mcp-server#2740 ·
Todas as issues de github/github-mcp-server
Issues semelhantes
-
area/dev-productivity area/disaster-recovery area/ipcei kind/enhancement
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 70/100
-
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 85/100
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
-
kind/bug status/0-triage
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
-
🤔 refinement needed
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
equinor/radix-operator#1979 ·