Honor PERL_JSON_BACKEND=JSON::XS through the bundled compatibility shim
Mantenedores costumam responder em até 1 dia
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 4/5
- Tempo estimado
- 3-5 dias
- Facilidade para iniciantes
- 58/100
Direção de pesquisa
Start with src/main/perl/lib/JSON.pm and the existing adapter in src/main/perl/lib/JSON/XS.pm; compare how the dispatcher handles PERL_JSON_BACKEND with how the adapter reports its backend and native XS status. Add the project owned regression described in the acceptance criteria, first checking its expected behavior with system Perl. Run it on both JVM and interpreter backends, then verify the default and JSON::backportPP selections and the CPAN distribution test.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Summary
The bundled JSON dispatcher ignores PERL_JSON_BACKEND=JSON::XS. It always loads JSON::PP unless the value is exactly JSON::backportPP, and JSON->backend consequently reports JSON::PP. This makes CPAN distributions that explicitly request the XS-compatible backend fail even though PerlOnJava already ships a JSON::XS compatibility module backed by the bundled pure-Perl JSON implementation.
Reproduction
With PERL_JSON_BACKEND=JSON::XS, run:
./jperl -e 'require JSON; print JSON->backend, "\n"'
./jperl --interpreter -e 'require JSON; print JSON->backend, "\n"'
Both currently print JSON::PP. The same selection occurs when the variable is set inside a test's BEGIN block before use JSON.
This was observed in CPAN random run 20261118-104825-43075 for Data-Compare-Plugins-JSON 1.04. t/05-compare-json-uses-xs.t sets PERL_JSON_BACKEND=JSON::XS, loads JSON::XS and JSON, then expects JSON->backend to be an isa JSON::XS. The PerlOnJava run reports JSON::PP and fails that assertion (1 of 75 tests; 1 of 11 test programs). The run used JSON 4.11, JSON::XS 4.04 and JSON::PP 4.18. The complete unmodified distribution suite passed under system Perl (11 files, 75 tests); the focused test also passed with the distribution and dependency library paths active.
Root cause and existing support
src/main/perl/lib/JSON.pm loads JSON::PP for every backend value other than JSON::backportPP, initializes $Backend / $BackendModule to JSON::PP, and leaves $BackendModuleXS undefined. Separately, src/main/perl/lib/JSON/XS.pm already exposes a JSON::XS-compatible API by delegating to Cpanel::JSON::XS, which uses the JSON::PP stack. The compatibility adapter is therefore present, but JSON never selects it when the caller requests JSON::XS.
The fix should connect the dispatcher to this existing adapter (or a small JSON::Backend::XS wrapper over it) when PERL_JSON_BACKEND=JSON::XS. It should preserve the distinction between selecting an XS-compatible API and actually running native XS: do not claim a native XS implementation is loaded. Keep the default PP selection and the JSON::backportPP behavior intact.
Acceptance criteria
- Add a project-owned regression for setting
PERL_JSON_BACKEND=JSON::XSbefore loadingJSON; validate the test's expected behavior with system Perl first. - On both JVM and interpreter backends, the requested
JSON::XSadapter is selected andJSON->backendsatisfiesisa JSON::XS. - The selected adapter continues to encode/decode through the bundled PP implementation and retains the existing
JSON::XSAPI behavior; native XS status is reported accurately. - Default backend selection and
PERL_JSON_BACKEND=JSON::backportPPremain unchanged. Data-Compare-Plugins-JSON1.04's unmodifiedt/05-compare-json-uses-xs.tand full suite pass through the normal PerlOnJava CPAN dependency overlay.
Related work
The existing JSON::XS shim is documented in docs/reference/xs-compatibility.md and implemented in src/main/perl/lib/JSON/XS.pm. Issue #1148 covers JSON::Parse loading without XS and is a separate problem. Issue #2097 concerns adding JSON::SL support; it may share JSON infrastructure, but does not cover backend selection.
- Linguagem predominante
- Perl
- Estrelas
- 67
- Forks
- 8
- Merge médio
- 5h 12min
- PRs com merge (30d)
- 131
Preparar o ambiente
- Inclui um Dockerfile ou arquivo Docker Compose
- Sem modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de fglock/PerlOnJava
-
area:cpan-port bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 70/100
fglock/PerlOnJava#2153 ·
Mantenedores costumam responder em até 1 dia
-
area:cpan-port area:parser bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 68/100
fglock/PerlOnJava#2137 ·
Mantenedores costumam responder em até 1 dia
-
area:backend area:cpan-port area:runtime bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 76/100
fglock/PerlOnJava#2071 ·
Mantenedores costumam responder em até 1 dia
-
area:runtime documentation enhancement
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
fglock/PerlOnJava#1579 ·
Mantenedores costumam responder em até 1 dia
-
area:cpan-port bug
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 62/100
fglock/PerlOnJava#2157 ·
Mantenedores costumam responder em até 1 dia
Todas as issues de fglock/PerlOnJava
Issues semelhantes
-
Dev-output directory preparation accepts file-valued lib/include paths and fails on dangling linksAbertateam-cli
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 70/100
Mantenedores costumam responder em até 2 dias
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 66/100
-
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 93/100
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 73/100
inverse-inc/packetfence#9728 ·
Mantenedores costumam responder em até 1 dia
-
fix(char-create): show the real reason a character is refusedTalvez já em andamento @baphomello assumiu há 1 dia. Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 84/100
Mantenedores costumam responder em até 1 dia