Incorrect bracket matching when JavaScript identifier contains $

Aberta
  • Algo errado?
#2,236 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
65/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
javascript
Domínio
devtools

Direção de pesquisa

Look at the bracket matching logic in the JavaScript editor, likely in a language server or syntax highlighting component. Start by searching for files handling bracket matching or tokenization for JavaScript. Reproduce the issue locally with the provided test case to confirm the bug. Check how '$' is being interpreted in identifiers and adjust the matching rules to treat it as part of an identifier, not a bracket.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

In the JavaScript editor, bracket matching incorrectly associates an opening { with a $ character instead of the corresponding closing }.

This is reproducible in a completely new, empty .js file, so it does not appear to be related to the project, existing source code, or workspace configuration.

Steps to reproduce
  1. Create a new empty JavaScript file, for example test.js.
  2. Enter the following code:
function test() {
    const $this = $(this);
}
  1. Place the cursor on the opening { after function test().
Actual result

The $ character in $this / $(this) is highlighted as the matching character.

For example:

function test() {
    const $this = $(this);
          ^

The $ is highlighted instead of the closing }.

Expected result

The corresponding closing brace should be highlighted:

function test() {
    const $this = $(this);         
}
^

The $ character is valid in JavaScript identifiers and should not be treated as a bracket or matching character.

Additional information

The problem is reproducible with a completely new JavaScript file containing only the above code.

Try removing the $s from the file and I see that NO } is highlighted

Environment
  • Eclipse IDE: 4.41
  • Eclipse Wild Web Developer: 1.4.1.202608181434
  • Feature: org.eclipse.wildwebdeveloper.feature.feature.group
  • Operating system: Windows
  • Language: JavaScript
Notes

The issue also occurs in existing JavaScript source code, including code using jQuery, but jQuery itself does not appear to be relevant because the minimal example above reproduces the problem.

The problem affects only the visual bracket matching/highlighting; the JavaScript code itself is valid.

Linguagem predominante
Java
Estrelas
203
Forks
76
Merge médio
1d 5h
PRs com merge (30d)
30

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de eclipse-wildwebdeveloper/wildwebdeveloper

Todas as issues de eclipse-wildwebdeveloper/wildwebdeveloper

Issues semelhantes

Mais issues de Java

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.