Treat span-like types with a unit of measure as byref-like

Aberta
  • Algo errado?
#20,907 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 2 dias

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
40/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Domínio
compilers

Direção de pesquisa

Start from isByrefLikeTyconRef and stripTyEqns in the compiler's type utilities, which the report says miss the representation of measure-annotated abbreviations. Run the repro with the TaggedSpan<kg> example and compare with the TaggedSpan<1> case, which already gives FS0406 and FS0412. Done means the kg version reports the same errors and existing byref-like tests still pass. The author already has a fix, so check with the maintainers before starting a parallel one.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Needs-Triage

A measure-annotated abbreviation of Span<int> is not treated as byref-like when its unit of measure is anything other than 1. The compiler then accepts code that captures such a value in a closure or uses its type as a type argument, and the program fails at run time.

open System
[<Measure>] type kg
[<MeasureAnnotatedAbbreviation>]
type TaggedSpan<[<Measure>] 'u> = Span<int>
let size (s: TaggedSpan<'u>) = 0

let capture (s: TaggedSpan<kg>) = let t = s in fun () -> size t
let instantiate (s: TaggedSpan<kg>) = id s

[<EntryPoint>]
let main args =
    let s = Unchecked.defaultof<TaggedSpan<kg>>
    if args.Length = 0 then capture s () else size (instantiate s)

Actual: this compiles with the .NET SDK 10.0.402 compiler and with main at fbc9be3. Compiled without optimization:

  • With no arguments, capture throws TypeLoadException: A ByRef or ByRef-like type cannot be used as the type for an instance field in a non-ByRef-like type.
  • With an argument, instantiate throws VerificationException: Method Microsoft.FSharp.Core.Operators.Identity: type argument 'System.Span`1[System.Int32]' violates the constraint of type parameter 'T'.

Expected: the errors the compiler reports when kg is replaced by 1: FS0406 on the closure in capture, and FS0412 on id s and on Unchecked.defaultof.

isByrefLikeTyconRef does not look at the representation of a measure-annotated type, and stripTyEqns reduces such a type to its representation only when the measure is dimensionless, so TaggedSpan<kg> is not recognised as byref-like. I found this while reviewing #20856, whose tests define TaggedSpan. I have a fix ready.

[!NOTE]
Prepared with AI assistance (Anthropic Claude, OpenAI Codex); Peter reviewed it.

Linguagem predominante
F#
Estrelas
4.3k
Forks
884
Merge médio
2d 11h
PRs com merge (30d)
73

Preparar o ambiente

Abrir no Codespaces

Inicia o contêiner de desenvolvimento do projeto no navegador, com a sua própria conta do GitHub.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de dotnet/fsharp

Todas as issues de dotnet/fsharp

Issues semelhantes

Mais issues de Compilers

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.