Remove Hardcoded Default Admin Username in Node.js Environment Config

Aberta
#170 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
72/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
docker, node.js, typescript

Direção de pesquisa

Start with apps/node/src/env.ts and trace how environment variables are validated and consumed at startup. Check .env.test.example, .dev.vars.example, and the Node/Docker self-hosting documentation for the required variable. Done means a missing or blank value produces the stated actionable error and the examples and documentation explain how to set it; run the listed typecheck, tests, and lint commands.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

bug good first issue

Summary

When running Codra in Node.js / Docker mode without explicitly setting DASHBOARD_ALLOWED_USERS, the application defaults to granting dashboard admin access to a hardcoded GitHub username (devarshishimpi). Self-hosting operators who do not set this variable are locked out of their own dashboard while an unintended user may have access.

Affected File

apps/node/src/env.ts lines 59-60:

DASHBOARD_ALLOWED_USERS:
  process.env.DASHBOARD_ALLOWED_USERS || "devarshishimpi",

Impact

  • A self-hoster who follows the quickstart (docker run -p 3000:3000 devarshishimpi/codra) without reading .env.example configures an instance that only allows devarshishimpi to log in.
  • The self-hoster cannot access their own dashboard.
  • If someone follows the Docker quickstart exactly as documented, they get a broken, inaccessible dashboard with no error message explaining why.

Proposed Fix

Replace the silent default with an explicit startup error:

const allowedUsers = process.env.DASHBOARD_ALLOWED_USERS;
if (!allowedUsers || allowedUsers.trim() === "") {
  throw new Error(
    "Missing required environment variable: DASHBOARD_ALLOWED_USERS\n" +
    "Set it to a comma-separated list of GitHub usernames that are allowed to access the dashboard.\n" +
    "Example: DASHBOARD_ALLOWED_USERS=your-github-username"
  );
}
DASHBOARD_ALLOWED_USERS: allowedUsers,

Additionally:

  • Update .env.test.example and .dev.vars.example to include a clear placeholder for DASHBOARD_ALLOWED_USERS
  • Update the Node/Docker setup documentation to call out this variable as required

Done When

  • Starting the Node server without DASHBOARD_ALLOWED_USERS set throws a clear, actionable startup error
  • .env.test.example and .dev.vars.example include a documented placeholder for this variable
  • The self-hosting documentation explains this variable is required
  • npm run typecheck, npm test, and npm run lint all pass
Linguagem predominante
TypeScript
Estrelas
125
Forks
23
Merge médio
2d 13h
PRs com merge (30d)
12

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de devarshishimpi/codra

Todas as issues de devarshishimpi/codra

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.