Parse review commands and support category focused reviews

Aberta
#155 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
52/100
Tipo de issue
Funcionalidade
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
github, node.js, typescript

Direção de pesquisa

Trace how GitHub comments are normalized and mention comments become review requests, then find the existing review category definitions and review configuration. Keep parsing in shared code used by Workers and Node/Docker. Done means both command forms and the existing default mention work, invalid commands receive a reply without starting a review, syntax is documented, and the requested checks pass.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

enhancement good first issue help wanted

Goal

Parse review commands in pull request comments and let a developer request either a full review or a review focused on one of Codra's existing review categories.

Current behavior

Codra starts a mention triggered review when a new pull request comment contains the repository's configured mention. The text after the mention is not parsed, so every matching comment starts the same kind of review.

What to build

  • Recognize review as a request for the existing full review behavior.
  • Recognize review focus <category> and pass the selected category into the review request.
  • Accept only categories Codra already supports. Do not add new review categories or a category specific command.
  • Use the repository's configured mention trigger, not a hard coded @codra-app string.
  • Return a concise reply when a command is incomplete or the category is unsupported.
  • Keep existing mention behavior working for users who do not include a command.

Implementation guidance

Start by tracing how GitHub comments are normalized and how mention comments become review requests. Reuse the existing review category definitions and review configuration. Keep command parsing in shared code where both runtime deployments can use it. Do not duplicate behavior separately for Workers and Node/Docker.

Done when

  • Full review and category focused review commands work.
  • Existing mention requests still start a full review.
  • Unsupported or incomplete commands receive a clear reply and do not start an unintended review.
  • Tests cover the default mention, a configured custom mention, each command form, and invalid input.
  • The supported syntax is documented with examples.
  • Any backend changes work in both Cloudflare Workers and Node/Docker.
  • npm run typecheck, npm test, and npm run lint all pass.
Linguagem predominante
TypeScript
Estrelas
125
Forks
23
Merge médio
2d 13h
PRs com merge (30d)
12

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de devarshishimpi/codra

Todas as issues de devarshishimpi/codra

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.