Allow selecting HTTP transport in DBSQLClient.connect()
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 2/5
- Tempo estimado
- 1-3 horas
- Facilidade para iniciantes
- 72/100
- Tipo de issue
- Funcionalidade
- Clareza
- Razoavelmente clara
- Status de atividade
- Ativa
- Stack de tecnologia
- node.js, typescript
- Domínio
- api, networking
Direção de pesquisa
Comece por lib/contracts/IDBSQLClient.ts e lib/DBSQLClient.ts e, em seguida, inspecione os testes existentes do transporte HTTP e o teste E2E do proxy HTTP. Confirme que as opções públicas de conexão expõem a configuração de transporte acordada, que HTTPS continua sendo o padrão e que uma seleção explícita de HTTP chega à implementação de conexão existente sem o workaround de método privado.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Summary
Please expose the existing HTTP transport support through the public DBSQLClient.connect() options.
I would be happy to submit a PR implementing this change if the maintainers agree with the proposed direction and public API.
The lower-level connection implementation supports both HTTP and HTTPS, but DBSQLClient currently hardcodes HTTPS.
Motivation
Some deployments connect to Databricks through a trusted local or internal reverse proxy, sidecar, or gateway:
Application --HTTP--> Internal proxy --HTTPS--> Databricks
In our concrete setup, authentication is also handled at the proxy level. The proxy injects the Databricks bearer token, while the application intentionally provides no authorization header.
This authentication arrangement is only one use case. The general issue is that callers cannot select the transport protocol for the endpoint supplied to DBSQLClient.
The existing proxy option does not address this scenario because it represents a forward proxy using CONNECT semantics, rather than a reverse proxy exposed as the Databricks endpoint.
Current behavior
The public ConnectionOptions type in lib/contracts/IDBSQLClient.ts does not expose an HTTP/HTTPS option.
Additionally, DBSQLClient.getConnectionOptions() in lib/DBSQLClient.ts hardcodes:
https: true,
Consequently, passing an untyped https: false value does not work: it is discarded and the client still connects using an https:// URL.
The internal implementation already appears to support the requested behavior:
IConnectionOptionsincludeshttps?: booleanHttpConnectionselects eitherhttp.Agentorhttps.AgentHttpConnectionconstructs either anhttp://orhttps://URL- existing tests exercise the HTTP behavior
- the HTTP proxy E2E test overrides
getConnectionOptions()to sethttps = false
Proposed API
Expose the existing option publicly while preserving HTTPS as the default:
await client.connect({
host: 'localhost',
port: 3015,
path: '/proxy/databricks/sql/1.0/warehouses/<warehouse-id>',
https: false,
authType: 'custom',
provider: {
async authenticate() {
return {};
},
},
});
The implementation could map it as follows:
https: options.https ?? true,
Alternatively, a more explicit public option could be introduced:
protocol?: 'http' | 'https';
HTTPS should remain the default, and HTTP should require explicit opt-in.
Current workaround
We currently override the private connection-options mapper:
type PublicConnectionOptions = Parameters<DBSQLClient['connect']>[0];
type InternalConnectionOptions = {
https?: boolean;
[key: string]: unknown;
};
type ClientConnectionOptionsFactory = {
getConnectionOptions(
options: PublicConnectionOptions,
): InternalConnectionOptions;
};
const client = new DBSQLClient();
const internalClient =
client as unknown as ClientConnectionOptionsFactory;
const getConnectionOptions =
internalClient.getConnectionOptions.bind(client);
internalClient.getConnectionOptions = (options) => ({
...getConnectionOptions(options),
https: false,
});
This works end to end and preserves the driver's normal connection handling, but it relies on a private method and may break between releases.
Security considerations
Plain HTTP should be documented as appropriate only for trusted local or private-network connections.
In our setup:
- the application-to-proxy connection is local/internal
- the proxy injects the Databricks token at the proxy layer
- the application does not send Databricks credentials over HTTP
- the proxy-to-Databricks connection uses HTTPS
Environment
@databricks/sql: 2.0.0
- Linguagem predominante
- TypeScript
- Estrelas
- 36
- Forks
- 50
- Merge médio
- 13h 46min
- PRs com merge (30d)
- 9
Guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de databricks/databricks-sql-nodejs
-
Docs folder deleted in 1.8.4 Abertaengineer-bot
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 64/100
databricks/databricks-sql-nodejs#274 · 1 comentário · 1 reação ·
-
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 68/100
-
Dificuldade 4/5 3-5 dias Facilidade para iniciantes 35/100
-
Dificuldade 4/5 3-5 dias Facilidade para iniciantes 48/100
-
Dificuldade 4/5 3-5 dias Facilidade para iniciantes 52/100
Todas as issues de databricks/databricks-sql-nodejs
Issues semelhantes
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 84/100
Eynzof/Hermes-CN-Desktop#610 ·
-
[Bug]: Matrix progress drafts fail with "Matrix runtime not initialized" during tool activity Abertabug clawsweeper:linked-pr-open clawsweeper:needs-live-repro clawsweeper:no-new-fix-pr impact:message-loss issue-rating: 🐚 platinum hermit P2 regression
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
-
enhancement
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 68/100
-
calcite-components needs triage refactor
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
Esri/calcite-design-system#15203 ·
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 90/100
danielmiessler/LifeOS#2218 ·