Ruby: a Rakefile's `warning = true` is never read, Cucumber features are not tests, project runner scripts (test/runner, brew tests/style/typecheck, ruby test/*.rb) are not runners
Mantenedores costumam responder em até 1 dia
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 4/5
- Tempo estimado
- 3-5 dias
- Facilidade para iniciantes
- 22/100
- Tipo de issue
- Bug
- Clareza
- Razoavelmente clara
- Status de atividade
- Ativa
- Domínio
- testing-qa, tooling
Direção de pesquisa
Start with the Ruby checks in ecosystems/ruby/practices.py, where RUBY_WARNING_SETTINGS reads only .rspec and the TEST_HELPERS tuple defined in ecosystems/ruby/init.py, and with docs/ecosystems/ruby.md, which says a test task's warning = true counts. Reproduce the fluentd case with a Rakefile setting t.warning = true and check the warning requirement fails. Done means the Rakefile setting is detected, and runners such as test/runner, ruby test/*.rb and .feature files are classified correctly, which needs maintainer agreement on scope first.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
fluentd sets warning = true on the Rake::TestTask that rake test runs (docs/ecosystems/ruby.md says it counts) but RUBY_WARNING_SETTINGS never reads Rakefiles → FAIL "missing Ruby warnings". rspec's 140 .feature files (run by script/run_cucumber) are unrecognised. puma runs its Minitest suite through test/runner; fzf runs minitest with ruby test/…rb directly; Homebrew runs RuboCop/shellcheck/shfmt (brew style), Sorbet (brew typecheck) and RSpec (brew tests) through its own commands.
Evidence from the corpus audit
junegunn/fzf / tests-run (Ruby)
- kind: FALSE_NEGATIVE
- actual: WARN (Ruby place):
tests found in 9 file(s), but no CI configuration runs rspec, rake test or rails test - expected: PASS: both CI jobs run the minitest suite directly with
ruby. - evidence:
.github/workflows/linux.yml:62:run: make install && ./install --all && tmux new-session -d && ruby test/runner.rb --verbose;.github/workflows/macos.yml:45:run: make install && ./install --all && LC_ALL=C tmux new-session -d && ruby test/test_go.rb --verbose;Gemfile:5:gem 'minitest', '5.25.4';Makefile:98,101:itest:...'tmux -f /dev/null new-session -d && ruby test/runner.rb; s=$$?; tmux kill-server; exit $$s'; \ - evidence (validator): docs/ecosystems/ruby.md:7-8: tests are run "by rspec,
rake test/specorrails test, or by the Rakefile's test tasks";ruby test/<file>.rb(minitest's native way) is not a runner. - repro:
Gemfilewith minitest,test/test_x.rb, workflowrun: ruby test/test_x.rb. - confidence: medium
fluent/fluentd / compiler-warnings (Rakefile warning = true never read)
- kind: FALSE_NEGATIVE
- actual: FAIL: "Ruby: missing Ruby warning settings: Ruby warnings; found RuboCop or Standard"
- expected: PASS:
docs/ecosystems/ruby.mdsays a test task'swarning = truecounts, and fluentd's Rakefile sets it on theRake::TestTaskthatrake test(what CI runs) depends on. The setting is in fact never read from a Rakefile:RUBY_WARNING_SETTINGSreads only.rspecand the test helpers. - evidence:
Rakefile:11:task test: [:base_test];Rakefile:29:Rake::TestTask.new(:base_test) do |t|;Rakefile:48:t.warning = true;.github/workflows/test.yml:56:run: bundle exec rake test TESTOPTS="-v --report-slow-tests --no-show-detail-immediately".--answers(compiler-warnings, Ruby):"found": {"RuboCop or Standard": ["CI (.github/workflows/rubocop.yml)"]}, "missing": ["Ruby warnings"]. Validatorecosystems/ruby/practices.py:33-35:RUBY_WARNING_SETTINGS = requirement_reader("Ruby warning settings", (".rspec", *TEST_HELPERS), ...)withecosystems/ruby/__init__.py:32:TEST_HELPERS = (".simplecov", "spec/spec_helper.rb", "spec/rails_helper.rb", "test/test_helper.rb")- no Rakefile. (sinatra's "found Ruby warnings" comes fromrack-protection/.rspec--warnings, not from its Rakefile'st.warning = true.) - repro:
RakefilewithRake::TestTask.new(:test) do |t| t.warning = true end, a workflow runningbundle exec rake test, Gemfile,test/test_foo.rb(scratch reprosa,a2(Minitest::TestTask),a3(default task),a4,a5: all FAIL "no Ruby warning settings found"). - confidence: high
puma/puma / tests-run
- kind: UNSUPPORTED
- actual: FAIL: "Ruby: tests found in 62 file(s), but no CI configuration runs rspec, rake test or rails test"
- expected: PASS: every test job compiles the extension with
bundle exec rake compileand then runs the suite through the repository's own Minitest runner scripttest/runner(a Ruby script that loads minitest); a project-specific runner, so a gap rather than a bug, but the result reads as "puma does not run its tests in CI", which is wrong. - evidence:
.github/workflows/tests.yml:132-134:- name: test...run: test/runner --verbose(and:194-196);test/runner:1-5:#!/usr/bin/env ruby...A simplified test runner; it runs all tests by default. It assumes that "bundle exec rake compile" has been run.;Rakefile:127:Rake::TestTask.new(:test) do |t|,:135:task :default => [:rubocop, :test]. - repro: workflow step
run: test/runner, wheretest/runneris a Ruby script withrequire "minitest/autorun"; expect the runner recognised when the script's head shows minitest (or at least an UNKNOWN rather than "no CI configuration runs"). - confidence: low
Homebrew/brew / code-formatting, static-analysis, type-checking, tests-run (brew's own dev commands)
- kind: UNSUPPORTED
- actual: code-formatting FAIL "Ruby: Library/Homebrew: ... is defined but CI does not run RuboCop, Standard or syntax_tree"; static-analysis FAIL "Ruby: RuboCop is configured ... but does not run; Shell: shellcheck is configured (.shellcheckrc) but does not run"; type-checking FAIL "Ruby: Library/Homebrew: Sorbet is configured (Library/Homebrew/sorbet/config) but does not run"; tests-run FAIL "Ruby: Library/Homebrew: tests found in 11 file(s), but no CI configuration runs rspec, rake test or rails test"
- expected: Homebrew runs all of these through its own dev commands:
brew style(RuboCop + shellcheck + shfmt),brew typecheck(Sorbetsrb tc),brew tests(RSpec); the four FAILs are all wrong for the real project. A project-specific wrapper, so a gap, but the biggest Ruby project in the corpus ends up with its whole CI invisible. - evidence:
.github/workflows/tests.yml:62:- run: brew style;:64:- run: brew typecheck;:97:run: brew style homebrew/core homebrew/cask; thetests (...)matrix jobs (.allow.txtplatform-matrix linestests (Linux, 1/2),tests (macOS, 1/2), ...) runbrew tests;Library/Homebrew/dev-cmd/typecheck.rb(named insorbet.yml:6). - repro: unclear (would need per-project command aliases, e.g. a
--run-as "brew style=rubocop"mapping or readingLibrary/Homebrew/dev-cmd/*.rb) - confidence: medium
rspec/rspec / tests-run (Cucumber)
- kind: UNSUPPORTED
- actual:
unrecognised_suffixes:.feature(140 files); tests-run PASS for Ruby credits only the RSpec specs. - expected: Cucumber features are a standard Ruby acceptance-test format and CI runs them (
script/run_cucumber); they should count as tests and.featureshould not be "unrecognised". - evidence:
.github/workflows/rspec.yml:53:- run: ../script/run_cucumber;rspec-core/features/*.featureetc. (140 files). - repro:
features/x.featureplus a workflow runningbundle exec cucumber; expect tests found and run. - confidence: low
Found by the regression-corpus audit (235 real repositories, one or more per ecosystem profile; corpus and expected results in corpus/). Evidence is quoted from the audited checkouts at the commits pinned in corpus/projects.toml; <checkouts>/<owner>__<repo> is such a checkout.
🤖 Generated with Claude Code
- Linguagem predominante
- Python
- Estrelas
- 4
- Forks
- 1
- Merge médio
- 10h 41min
- PRs com merge (30d)
- 79
Preparar o ambiente
Este projeto não oferece contêiner de desenvolvimento, Dockerfile nem guia de contribuição, então a configuração fica por sua conta: comece pelo README e veja nosso guia da primeira contribuição para os passos gerais.
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de cpp-best-practices/project_validator
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 62/100
cpp-best-practices/project_validator#267 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 68/100
cpp-best-practices/project_validator#263 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 62/100
cpp-best-practices/project_validator#260 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 74/100
cpp-best-practices/project_validator#259 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 65/100
cpp-best-practices/project_validator#255 ·
Mantenedores costumam responder em até 1 dia
Todas as issues de cpp-best-practices/project_validator
Issues semelhantes
-
add entry to blockAberta
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 65/100
StevenBlack/hosts#3299 ·
-
`garak --report` overwrites the input report when its name has no ".report"Talvez já em andamento @0z5a assumiu hoje. Abertaneeds-triage
Dificuldade 2/5 Meio dia Facilidade para iniciantes 72/100
Mantenedores costumam responder em até 2 dias
-
plot_graph crashes when a mesh node has no m2m edgeTalvez já em andamento @tygvi assumiu hoje. Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
mllam/neural-lam#883 · 1 comentário ·
Mantenedores costumam responder em até 2 dias
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 62/100
future-agi/future-agi#4092 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
transcript analytics: a text whose only protected spans the prose pass redacts is withheld wholeAberta
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 82/100
WingedGuardian/GENesis-AGI#4641 ·
Mantenedores costumam responder em até 1 dia