fix(core): Cohere and Voyage rerankers bypass non-positive limit check on NaN topN and send invalid null payload

Fechada
  • Algo errado?
#582 3 comentários 0 reações 1 responsável Ver no GitHub

Mantenedores costumam responder em até 1 dia

@bhushan4work já está trabalhando nisso.

Desde 3/11/2026.

  • #589 de @bhushan4work — integrado

Avaliação

Esta issue ainda não foi avaliada.

Descrição

bug core
Which part?

@chatcops/core

Package version

No response

What happened?
Problem

In both cohereReranker and voyageReranker, candidate reranking enforces the requested limit using:
const limit = Math.floor(topN);
if (chunks.length === 0 || limit <= 0) return [];
If topN evaluates to NaN (such as when parsing unvalidated query/input parameters into retrieval plans), Math.floor(NaN) evaluates to NaN. In JavaScript /
IEEE 754 arithmetic, relational comparisons with NaN (NaN <= 0) always evaluate to false.

Consequently, the early return check is bypassed:

  1. Math.min(limit, chunks.length) calculates Math.min(NaN, chunks.length), which returns NaN.
  2. When serialized for outbound HTTP calls, JSON.stringify converts NaN to null:
    • Cohere receives: {"top_n": null}
    • Voyage receives: {"top_k": null}
  3. Both Cohere and Voyage AI endpoints reject null values with HTTP 400 Bad Request (e.g. invalid request: top_n must be a positive integer), triggering an
    unhandled provider error in postWithRetries that aborts the chat/retrieval turn.
    By contrast, workersAiReranker correctly protects against this:
    const requestedLimit = Number.isFinite(topN) && topN > 0 ? Math.floor(topN) : 0;
    if (!requestedLimit || !chunks.length) return [];
Actual Behavior

• Actual Behavior: Calling rerank(query, chunks, NaN) bypasses the non-positive limit guard, triggers an outbound HTTP request with top_n: null or top_k:
null, and fails with HTTP 400 Bad Request.

Impact

• Any unvalidated or non-numeric topK / topN value passed directly to rerankers or computed via plan() results in an unnecessary outbound API call that fails
with an unhandled HTTP 400 error.
• Causes behavioral inconsistency across @chatcops/core rerankers (workersAiReranker returns [], while cohereReranker and voyageReranker fail with provider
errors).

Acceptance Criteria

• cohereReranker and voyageReranker validate that topN is a positive finite number (e.g., using Number.isFinite(topN) && topN > 0) before making outbound
requests.
• Invoking rerank with NaN or non-finite topN returns [] immediately without sending network requests.
• Test suites in cohere-reranker.test.ts and voyage-reranker.test.ts include assertions for non-finite topN values.

What did you expect?

• Expected Behavior: Calling rerank(query, chunks, NaN) should recognize non-finite / invalid counts, return [] immediately, and avoid making unnecessary
outbound API calls.

How can we reproduce it?
1. Initialize a reranker instance:
    const reranker = cohereReranker({ apiKey: 'dummy-key', fetch: mockFetch });

  2. Call rerank with non-empty chunks and NaN:
    await reranker.rerank('query', [{ id: '1', text: 'chunk' }], NaN);

  3. Inspect mockFetch: instead of returning [] without dispatching a network call (like topN = 0 does), a request is dispatched with body:
    { "model": "rerank-v5.0-pro", "query": "query", "documents": ["chunk"], "top_n": null }
Environment

No response

Linguagem predominante
TypeScript
Estrelas
13
Forks
7
Merge médio
3h 14min
PRs com merge (30d)
332

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de codercops/chatcops

Todas as issues de codercops/chatcops

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.