Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

RFC: GithubRepo is modeled incorrectly

Aberta
#1,083 4 comentários 0 reações 1 responsável Ver no GitHub

@begedin já está trabalhando nisso.

Desde 16/11/2017.

Avaliação

Esta issue ainda não foi avaliada.

Descrição

needs clarification RFC

Problem

#1080 added a unique index to the github_repos schema.

#1081 also changes behavior when syncing github repos to match by github_id

The model for a GithubRepo, however, looks like this (important bits only):

schema "github_repos" do
  field :github_id, :integer

  belongs_to :github_app_installation, CodeCorps.GithubAppInstallation
end

The problem here is, in a real world, a github repository is not uniquely identified by an installation, but by it's github_id, as we are aiming to change.

In our specific case, a belongs_to :github_app_installation simply tells us which installation provided us with the information about the repository.

I guess our initial goal was to model it so each installation stores it's own copy, even though, on github, it's the same record. With the addition of other records, this no longer works optimally.

However, with the way it all works, since in our model, a repo can only belong to a single installation, we will encounter A LOT of difficulties as we start dealing with multiple installations.

Proposed general solution

  • remove the "belongs_to" relationship
  • add a "link" table and change it to a many-to-many relationship
    • not sure about naming GithubAppInstallationGithubRepo, GithubInstallationRepo? GithubAppInstallationRepo, InstallationGithubRepo? GithubAppInstallationRepo sounds best to me.

Specific changes needed

In CodeCorps.GitHub.Event.Installation.Repos

  • the :delete_repos, :sync_repos steps are replaced with
    • :ensure_repos - find or create al repositories
    • :disassociate_repos - delete GithubAppInstallationRepo records no longer in the installation
    • :associate_repos - create GithubAppInstallationRepo records in the installation
Linguagem predominante
Elixir
Estrelas
234
Forks
82
Nenhum PR com merge em 30d

Guia de contribuição

Abrir o guia de contribuição

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de code-corps/code-corps-api

Todas as issues de code-corps/code-corps-api

Issues semelhantes

Mais issues de Elixir

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.