Yarn Berry is detected after Yarn Classic is installed, so Berry projects fail at yarn --version --loglevel notice

Aberta
#996 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
74/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
go, node.js
Domínio
build-system

Direção de pesquisa

Start in src/nodejs/supply/supply.go, tracing the order of Run(), ReadPackageJSON(), and the UsesYarnBerry check. Find the existing unit-test setup for Yarn installation and add a case with .yarnrc.yml that verifies InstallYarnBerry() is called, not InstallYarn(); run the relevant Go tests. Done means Berry is selected before installation for Berry projects.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

What happened

A Yarn 4 project (yarn.lock, .yarnrc.yml with yarnPath, and packageManager: [email protected]) fails during supply on v1.9.6. The buildpack installs Yarn Classic 1.22.22 instead of yarn-berry, then runs yarn --version --loglevel notice. Classic hands off to the project's Yarn 4 release through yarnPath, and Yarn 4 rejects the option:

Unknown Syntax Error: Unsupported option name ("--loglevel").
Cause

In src/nodejs/supply/supply.go, Run() chooses between InstallYarnBerry() and InstallYarn() based on s.UsesYarnBerry (around line 136). That flag is only set later, inside ReadPackageJSON() (called around line 158), where .yarnrc.yml is detected (around line 444). When the install choice is made, UsesYarnBerry is always false, so Berry projects always get Classic. The same ordering is on master and v1.9.7.

Removing yarnPath gets past the version check, but Build() then calls buildBerry() with Classic on PATH. Classic refuses to run because packageManager pins Yarn 4.

Suggested fix

Detect yarn.lock and .yarnrc.yml before the Yarn install step. For example, move that detection out of ReadPackageJSON() into a step that runs before the UsesYarnBerry check in Run(), or call ReadPackageJSON() before installing the package manager. A unit test where .yarnrc.yml is present should check that InstallYarnBerry() is called and InstallYarn() is not.

Environment
  • Buildpack: v1.9.6 (same code in v1.9.7 and master)
  • Stack: cflinuxfs4
  • Yarn: 4.18.1, nodeLinker: node-modules
Linguagem predominante
Go
Estrelas
174
Forks
390
Merge médio
15h 51min
PRs com merge (30d)
21

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de cloudfoundry/nodejs-buildpack

Todas as issues de cloudfoundry/nodejs-buildpack

Issues semelhantes

Mais issues de Go

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.