Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

[Bug] File descriptor leak in CLI CSV import: CSVParser from readCsvFile is never closed

Aberta
  • Algo errado?
#18,237 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
76/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Pouca atividade
Stack de tecnologia
java
Domínio
cli

Direção de pesquisa

Comece lendo AbstractDataTool.readCsvFile e os pontos de entrada de importação nomeados: ImportData.importFromSingleFile, ImportDataTree.importFromCsvFile, ImportDataTable.importFromCsvFile e ImportSchemaTree.importSchemaFromCsvFile. Reproduza o problema com muitos arquivos CSV pequenos sob um ulimit baixo e, em seguida, verifique se todo parser é fechado na conclusão normal e em retornos antecipados, sem esgotar os descritores de arquivo.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Search before asking
  • I searched in the issues and found nothing similar.
Version

master (2.0.x). The affected code is also present in released 2.0.x versions.

Describe the bug and provide the minimal reproduce step

AbstractDataTool.readCsvFile(String) builds a CSVParser over new InputStreamReader(new FileInputStream(path)) and returns it. The CSVParser owns that FileInputStream, but the CLI import code paths that call it never close the returned parser — it is assigned to a local inside a plain try { ... } block (no try-with-resources, no finally). Every imported file therefore leaks its file descriptor, and the early returns for an empty file or an invalid header leak it immediately, because the parser is opened before those checks run.

Affected call sites (current master, also present in released 2.0.x):

  • iotdb-client/cli/src/main/java/org/apache/iotdb/tool/data/ImportData.java — importFromSingleFile
  • iotdb-client/cli/src/main/java/org/apache/iotdb/tool/data/ImportDataTree.java — importFromCsvFile
  • iotdb-client/cli/src/main/java/org/apache/iotdb/tool/data/ImportDataTable.java — importFromCsvFile
  • iotdb-client/cli/src/main/java/org/apache/iotdb/tool/schema/ImportSchemaTree.java — importSchemaFromCsvFile (this class has its own copy of readCsvFile)

Minimal reproduce step:

  1. Create a directory containing a large number of small CSV files — more than the process open-file limit (for example a few thousand files under ulimit -n 1024).
  2. Run the CLI data import over that directory.
  3. The import fails partway through with Too many open files. (A single import already leaks one descriptor; it is simply not fatal until enough accumulate.)
What did you expect to see?

Each CSVParser (and the FileInputStream it wraps) is closed after the file is processed, on every exit path — including the empty-file / invalid-header early returns. Importing a large directory of CSV files should not exhaust the process's file descriptors.

What did you see instead?

The CSVParser returned by readCsvFile is never closed, so its underlying FileInputStream stays open. Importing a directory with enough CSV files leaks descriptors until the import fails with Too many open files.

Anything else?

The record Stream is fully consumed inside the same block before the method returns, so consuming each parser in a try-with-resources (closing it on scope exit) is safe.

Are you willing to submit a PR?
  • I'm willing to submit a PR!
Linguagem predominante
Java
Estrelas
6.4k
Forks
1.2k
Merge médio
1d 17h
PRs com merge (30d)
152

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de apache/iotdb

Todas as issues de apache/iotdb

Issues semelhantes

Mais issues de Java

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.