`MoveTowardsLeafNodes` placement implies speculative evaluation, but the docs don't say so

Aberta Para iniciantes
#27,487 3 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

@Inf1mum já está trabalhando nisso.

Desde 17/11/2026.

  • #27519 de @Inf1mum — aberto

Avaliação

Dificuldade
2/5
Tempo estimado
1-3 horas
Facilidade para iniciantes
75/100
Tipo de issue
Documentação
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
rust

Direção de pesquisa

Comece pela documentação de ExpressionPlacement::MoveTowardsLeafNodes e ScalarUDFImpl::placement, que estão vinculadas na issue. Leia como a extração e o pushdown de expressões folha podem avaliar expressões em linhas excluídas por ramificações de CASE ou filtros e, em seguida, documente o requisito de segurança em ambas as APIs. O trabalho estará concluído quando as duas documentações afirmarem que expressões com esse posicionamento não podem falhar nem ter efeitos colaterais em nenhuma linha de entrada.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Describe the bug

ExpressionPlacement::MoveTowardsLeafNodes is documented as a performance hint: the expression is cheap and can be pushed down towards the leaves of the plan. When the optimizer acts on that hint, it also runs the expression on rows that the original plan never evaluated it on:

  • ExtractLeafExpressions extracts MoveTowardsLeafNodes sub-expressions from anywhere inside an expression tree, including the branches of CASE. In the extraction projection, they are evaluated for every input row, not just the rows the branch selects.
  • PushDownLeafProjections then pushes the extraction projections below Filter nodes, so the expressions also run on rows the filter removes.

So an expression with this placement must be safe to evaluate on rows that a filter or a conditional would exclude: it must not fail on them or have side effects. Neither ExpressionPlacement::MoveTowardsLeafNodes nor ScalarUDFImpl::placement states this. The built-in functions with this placement (get_field, input_file_name, file_row_index) meet the requirement as far as I can tell. A user-defined function that returns MoveTowardsLeafNodes because it is cheap, but fails on some inputs, can make a query fail even though SQL CASE and WHERE semantics say that input is never evaluated.

To Reproduce

The plan below shows how get_field is moved with the default configuration (datafusion.optimizer.enable_leaf_expression_pushdown = true):

CREATE TABLE t AS SELECT * FROM (VALUES
  (1,  named_struct('a', 1, 'b', 2)),
  (-1, named_struct('a', 3, 'b', 4))
) AS v(x, s);

EXPLAIN SELECT CASE WHEN x > 0 THEN s['a'] WHEN x < -100 THEN 0 END FROM t WHERE x <> 5;
logical_plan
01)Projection: CASE WHEN t.x > Int64(0) THEN __datafusion_extracted_1 WHEN t.x < Int64(-100) THEN Int64(0) END AS ...
02)--Filter: t.x != Int64(5)
03)----Projection: get_field(t.s, Utf8("a")) AS __datafusion_extracted_1, t.x
04)------TableScan: t projection=[x, s]

get_field(t.s, 'a') came from the first THEN branch, and it is now evaluated below the filter for every row of t.

Replace s['a'] with a UDF that returns MoveTowardsLeafNodes and fails on some values, for example a checked conversion that fails when its argument is 0. The query then fails on rows where x <= 0 or x = 5, even though the result would never include the UDF's value for those rows.

Expected behavior

Either of these would resolve it:

  1. Document the requirement (preferred). State on ExpressionPlacement::MoveTowardsLeafNodes and ScalarUDFImpl::placement that an expression with this placement may be evaluated on rows that enclosing filters or conditional expressions would exclude, so it must not fail or have side effects on any input row. This matches what the optimizer already relies on.
  2. Stop speculative evaluation: don't extract leaf expressions from conditional sub-expressions (CASE branches, the right side of short-circuiting AND/OR), and don't push extraction projections below filters when the extracted expression could fail. That would give up much of the benefit of the leaf pushdown optimization, which is mainly about evaluating get_field close to the scan.
Additional context

The question came up while reviewing #26589, which precomputes MoveTowardsLeafNodes expressions over the whole batch before evaluating CASE branches (https://github.com/apache/datafusion/pull/26589#discussion_r4581490634). That PR relies on the same assumption at the physical level, so documenting the requirement would cover both.

Linguagem predominante
Rust
Estrelas
9.6k
Forks
2.6k
Merge médio
3d 5h
PRs com merge (30d)
352

Preparar o ambiente

Abrir no Codespaces

Inicia o contêiner de desenvolvimento do projeto no navegador, com a sua própria conta do GitHub.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de apache/datafusion

Todas as issues de apache/datafusion

Issues semelhantes

Mais issues de Rust

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.